The Wayback Machine - https://web.archive.org/web/20201127045728/https://github.com/litehtml/litehtml/pull/111
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection: initial implementation for text selection #111

Open
wants to merge 3 commits into
base: master
from

Conversation

@matzipan
Copy link

@matzipan matzipan commented Oct 13, 2019

Initial implementation for selection handling class, raised in #66

Still to do:

  • Improve selection active status management. For example, stop the selection from being active on button mouse up or on mouse leave
  • Move pango implementation to its own container
  • Return range of elements covered by the selection
  • Implement rendering for selection box
  • Implement method which returns the selected text
@matzipan matzipan force-pushed the matzipan:master branch from 303cff8 to 370b84f Oct 13, 2019
@tordex
Copy link
Member

@tordex tordex commented Oct 13, 2019

@matzipan thank you for your work. I need some time to investigate your code. But right now I have one suggestion: if this is possible, do not rewrite the existing containers. Just create other folder and place your Pango based container there. I guess this is the better way.

@matzipan
Copy link
Author

@matzipan matzipan commented Oct 13, 2019

But right now I have one suggestion: if this is possible, do not rewrite the existing containers.

Ah yeah that makes perfect sense. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.