Error object differs between pg and pg-native #938

deyhle · 2016-02-15T17:28:17Z

node-postgres abstracts over the pg-native module to provide exactly the same interface as the pure JavaScript version. No other code changes are required. If you find yourself having to change code other than the require statement when switching from require('pg') to require('pg').native please report an issue.

The fix for #743 made me test a switch to pg-native again. However, I still found an API difference: the Error object. While the default pg library returns an error with properties code and detail, the parameters are named differently when using pg-native.

require('pg'):

{
  "name": "error",
  "length": 199,
  "severity": "ERROR",
  "code": "23505",
  "detail": "Key (c1)=(one) already exists.",
  "schema": "public",
  "table": "dbhandlertest",
  "constraint": "dbhandlertest_pkey",
  "file": "nbtinsert.c",
  "line": "402",
  "routine": "_bt_check_unique"
}

require('pg').native:

{
  "severity": "ERROR",
  "sqlState": "23505",
  "messagePrimary": "duplicate key value violates unique constraint \"dbhandlertest_pkey\"",
  "messageDetail": "Key (c1)=(one) already exists.",
  "sourceFile": "nbtinsert.c",
  "sourceLine": "402",
  "sourceFunction": "_bt_check_unique"
}

This makes it hard to do proper error handling. Especially the code property is probably used a lot for that.

brianc · 2017-06-06T20:46:14Z

Adding to the [email protected] release milestone to normalize these fields across the native bindings & the pure javascript library.

vitaly-t · 2017-06-06T20:59:55Z

This makes it hard to do proper error handling. Especially the code property is probably used a lot for that.

In the meantime, the generic error handler can simply accept the native flag and parse errors differently.


        Normalize native error properties

Map native error properties to the same property names we use for errors from the JS driver. Fixes #972 Fixes #938


        Remove fallbacks for unsupported Node versions (#1304) (#1313)

* Add client connectionString tests (#1310) * Remove redundant tests * Add client connectionString test Add test to ensure { connectionString } is respected as an argument to the client constructor * Add test for connection string property Also fixed some legacy require statements. * Normalize native error properties Map native error properties to the same property names we use for errors from the JS driver. Fixes #972 Fixes #938

brianc · 2017-06-09T02:54:26Z

I have this fixed on the 7.0 branch.


        Remove fallbacks for unsupported Node versions (#1304) (#1313)

* Add client connectionString tests (#1310) * Remove redundant tests * Add client connectionString test Add test to ensure { connectionString } is respected as an argument to the client constructor * Add test for connection string property Also fixed some legacy require statements. * Normalize native error properties Map native error properties to the same property names we use for errors from the JS driver. Fixes #972 Fixes #938

abenhamdine mentioned this issue Feb 16, 2016

Postgres Native Error Code Change #919

Closed

kevinburkeshyp mentioned this issue Mar 29, 2016

Standardizing on a single error type #972

Closed

vitaly-t mentioned this issue Apr 7, 2016

Verbose Error not shown correctly in pg.native #982

Closed

brianc added this to the [email protected] milestone Jun 6, 2017

brianc added a commit that referenced this issue Jun 9, 2017

Normalize native error properties

Loading status checks…

056f42c

Map native error properties to the same property names we use for errors from the JS driver. Fixes #972 Fixes #938

brianc closed this Jun 9, 2017

Aug	SEP	Oct
	06
2019	2020	2021

brianc / node-postgres

Error object differs between pg and pg-native #938

Error object differs between pg and pg-native #938

deyhle commented Feb 15, 2016

brianc commented Jun 6, 2017

vitaly-t commented Jun 6, 2017

brianc commented Jun 9, 2017

brianc / node-postgres

Sponsor brianc/node-postgres

Join GitHub today

Error object differs between pg and pg-native #938

Error object differs between pg and pg-native #938

Comments

deyhle commented Feb 15, 2016

brianc commented Jun 6, 2017

vitaly-t commented Jun 6, 2017

brianc commented Jun 9, 2017