The Wayback Machine - https://web.archive.org/web/20201128215921/https://github.com/cebe/markdown/pull/170
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #169 #170

Open
wants to merge 1 commit into
base: master
from
Open

Fix #169 #170

wants to merge 1 commit into from

Conversation

@Soaku
Copy link

@Soaku Soaku commented Apr 10, 2019

Added so that GFM has support for creating line breaks by prefixing the line feed with a backslash.

I didn't add any render* function for the line breaks, since newlines rendered by renderText are never tokenized either. Is that okay?

On the side, here are some issues I've found:

  • Maybe trim the lines in the Markdown files in the repo to 120 characters per line? It's kinda annoying to view them.

  • The PHPDoc uses the @inheritDoc tag, not @inheritdocs, which is never mentioned in the docs, VSCode also doesn't highlight it. Dunno about PHPDoc itself, because I never used the software itself (Intellisense FTW). Intelephense (language server for PHP) does actually understand the tag, but that's only because it doesn't seem to check if there's a space after @inheritDoc, so even @inheritDocRandomStuffHere will work. I suspect the tag is not valid then.

  • composer-install outputs:

    Package facebook/xhprof is abandoned, you should avoid using it. Use lox/xhprof instead.
    Package phpunit/phpunit-mock-objects is abandoned, you should avoid using it. No replacement was suggested.
    
@Soaku

This comment has been minimized.

Copy link
Owner Author

@Soaku Soaku commented on CONTRIBUTING.md in b78ebd6 Apr 10, 2019

I fixed this dead link, aside from the rest of the commit.

The diff also contains some trailing whitespace removal, because I've set VSCode to do this automatically. I've disabled it for the tests, so they have the whitespace and work properly.

@Soaku
Copy link
Author

@Soaku Soaku commented Apr 10, 2019

What's wrong with Travis? It failed two builds during PHP/composer setup.

@k00ni
Copy link

@k00ni k00ni commented Jan 3, 2020

What is the status here?

@samdark
samdark approved these changes Jan 4, 2020
@samdark
Copy link
Contributor

@samdark samdark commented Jan 4, 2020

Looks OK. @cebe how about merging it?

@cebe cebe self-assigned this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.