Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Enable HTTP Compression on Linux #964
Conversation
CI build reports non-spurious failures for apt/Ubuntu with this change: 2018-11-11T00:06:04.2712520Z �[1;31m../Release/tests/functional/http/client/compression_tests.cpp:1322: error: Failure in compress_client_server: (rsp.content_ready().wait()) threw exception: Failed to decompress the response body FAILED |
@BillyONeal, can you re-run the CI build now that you've merged #963? It looks like that merge occurred later than this test run, and that error may be related. |
@epistor Sadly not :/ |
I cannot reproduce the failure on Ubuntu 16.04. in my VM. @BillyONeal Possibly there is a configuration issue in the Ubuntu_1604_Apt Job? Why is that PPA used and is it necessary to downgrade packages? |
@lepierre The default Pipelines VMs come with a PPA for later versions of PHP. Unfortunately that PPA comes with OpenSSL 1.1.x -- but the version of Boost that comes with 16.04 (1.58) doesn't work with OpenSSL 1.1.x. So we need to nuke that PPA to go back to the system default answer of OpenSSL 1.0.x. (More recent Boost works with 1.1.x just fine -- but the reason we want this to work is 16.04 is still what you get with a default Azure VM, and we want that to work) |
class gzip_decompressor : public zlib_decompressor_base
{
public:
gzip_decompressor() : zlib_decompressor_base(16) // gzip auto-detect
{
}
}; change 16 to 31? class gzip_decompressor : public zlib_decompressor_base
{
public:
gzip_decompressor() : zlib_decompressor_base(31) // gzip auto-detect
{
}
}; |
HTTP-Compression is enabled for Linux Systems. All tests pass successfully on my local Ubuntu 18.04. Machine.
Updates #863.