The Wayback Machine - https://web.archive.org/web/20201201004238/https://github.com/microsoft/cpprestsdk/pull/964
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP Compression on Linux #964

Closed

Conversation

@lepierre
Copy link

@lepierre lepierre commented Nov 9, 2018

HTTP-Compression is enabled for Linux Systems. All tests pass successfully on my local Ubuntu 18.04. Machine.
Updates #863.

Pierre Kurzer and others added 2 commits Sep 11, 2018
@BillyONeal BillyONeal self-requested a review Nov 12, 2018
Copy link
Member

@BillyONeal BillyONeal left a comment

CI build reports non-spurious failures for apt/Ubuntu with this change:

2018-11-11T00:06:04.2712520Z �[1;31m../Release/tests/functional/http/client/compression_tests.cpp:1322: error: Failure in compress_client_server: (rsp.content_ready().wait()) threw exception: Failed to decompress the response body FAILED

@epistor
Copy link
Contributor

@epistor epistor commented Nov 12, 2018

@BillyONeal, can you re-run the CI build now that you've merged #963? It looks like that merge occurred later than this test run, and that error may be related.

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 13, 2018

@epistor Sadly not :/

@lepierre
Copy link
Author

@lepierre lepierre commented Nov 13, 2018

I cannot reproduce the failure on Ubuntu 16.04. in my VM. @BillyONeal Possibly there is a configuration issue in the Ubuntu_1604_Apt Job? Why is that PPA used and is it necessary to downgrade packages?

@BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 13, 2018

@lepierre The default Pipelines VMs come with a PPA for later versions of PHP. Unfortunately that PPA comes with OpenSSL 1.1.x -- but the version of Boost that comes with 16.04 (1.58) doesn't work with OpenSSL 1.1.x. So we need to nuke that PPA to go back to the system default answer of OpenSSL 1.0.x.

(More recent Boost works with 1.1.x just fine -- but the reason we want this to work is 16.04 is still what you get with a default Azure VM, and we want that to work)

epistor referenced this pull request Nov 14, 2018
…e compress/decompress API
@BillyONeal BillyONeal closed this Mar 26, 2019
@dfhljf
Copy link

@dfhljf dfhljf commented Apr 29, 2019

CI build reports non-spurious failures for apt/Ubuntu with this change:

2018-11-11T00:06:04.2712520Z �[1;31m../Release/tests/functional/http/client/compression_tests.cpp:1322: error: Failure in compress_client_server: (rsp.content_ready().wait()) threw exception: Failed to decompress the response body FAILED

class gzip_decompressor : public zlib_decompressor_base
{
public:
    gzip_decompressor() : zlib_decompressor_base(16) // gzip auto-detect
    {
    }
};

change 16 to 31?

class gzip_decompressor : public zlib_decompressor_base
{
public:
    gzip_decompressor() : zlib_decompressor_base(31) // gzip auto-detect
    {
    }
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.