Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow building with HTTP compression support without WebSockets #875
Conversation
@@ -75,6 +75,7 @@ if(CPPREST_EXCLUDE_COMPRESSION) | |||
else() | |||
cpprest_find_zlib() | |||
target_link_libraries(cpprest PRIVATE cpprestsdk_zlib_internal) | |||
target_compile_definitions(cpprest PRIVATE -DCPPREST_HTTP_COMPRESSION=1) |
BillyONeal
Oct 1, 2018
Member
The macro CPPRESET_HTTP_COMPRESSION is an internal macro to http_helpers.cpp, and we shouldn't be messing with it from the build scripts like this.
The comment there indicates that the macro 'CPPREST_EXCLUDE_WEBSOCKETS is a flag that now essentially means "no external dependencies"', and zlib would be such an external dependency.
Perhaps the right thing is to change the bits in http_helpers.cpp to avoid checking CPPREST_EXCLUDE_WEBSOCKETS.
The macro CPPRESET_HTTP_COMPRESSION is an internal macro to http_helpers.cpp, and we shouldn't be messing with it from the build scripts like this.
The comment there indicates that the macro 'CPPREST_EXCLUDE_WEBSOCKETS is a flag that now essentially means "no external dependencies"', and zlib would be such an external dependency.
Perhaps the right thing is to change the bits in http_helpers.cpp to avoid checking CPPREST_EXCLUDE_WEBSOCKETS.
Obsoleted by PR #866. |
Currently, even if
CPPREST_EXCLUDE_COMPRESSION
is not set, HTTP compression support is disabled when WebSockets is disabled, even though it appears to only depend on zlib.This PR allows building the library with HTTP compression without a dependency on OpenSSL and Boost.