The Wayback Machine - https://web.archive.org/web/20201201010806/https://github.com/microsoft/cpprestsdk/issues/14
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #14

Open
elfring opened this issue Nov 10, 2015 · 1 comment
Open

reserved identifier violation #14

elfring opened this issue Nov 10, 2015 · 1 comment

Comments

@elfring
Copy link

@elfring elfring commented Nov 10, 2015

I would like to point out that identifiers like "_CASA_HTTP_CLIENT_H" and "_Value" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@ras0219-msft
Copy link
Contributor

@ras0219-msft ras0219-msft commented Nov 10, 2015

Yes, these identifiers are in violation of the expected naming convention for non-standard-library code, thanks for pointing this out :). We would love to have them changed but so far other issues have been more pressing.

I'm sure a PR for this would be gratefully accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.