Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Static lib compilation for UWP #26
Conversation
|
Hi @simonferquel, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@simonferquel, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| <DebugFileSuffix>d</DebugFileSuffix> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <TargetName>$(CppRestBaseFileName)140$(DebugFileSuffix)_uwp_$(CppRestSDKVersionFileSuffix)</TargetName> |
kavyako
Nov 30, 2015
Contributor
The import lib for the shared library cpprest140d_uwp_2_7.dll already has this name. I would prefer using different names here to minimize chances of mistaking the library type (import/static).
How about following a specific naming convention for static libs, say add _static suffix (cpprest140d_uwp_static_2_7.lib) or prepend the name with lib (libcpprest140d_uwp_2_7.lib).
The import lib for the shared library cpprest140d_uwp_2_7.dll already has this name. I would prefer using different names here to minimize chances of mistaking the library type (import/static).
How about following a specific naming convention for static libs, say add _static suffix (cpprest140d_uwp_static_2_7.lib) or prepend the name with lib (libcpprest140d_uwp_2_7.lib).
kavyako
Dec 1, 2015
Contributor
Some one suggested we can look at doing something similar to boost, http://www.boost.org/doc/libs/1_42_0/more/getting_started/windows.html#library-naming
If you are building a static library, use the lib prefix.
If the library is linking statically to the C++ standard library and compiler runtime support libraries, use s in the .lib name.
In this case, we are not linking statically to the runtime. so we can go with libcpprest140d_uwp_2_7.lib.
In future, if someone wants to add another version to link to the runtime statically, we can add _s to the name.
What do you think.
Some one suggested we can look at doing something similar to boost, http://www.boost.org/doc/libs/1_42_0/more/getting_started/windows.html#library-naming
If you are building a static library, use the lib prefix.
If the library is linking statically to the C++ standard library and compiler runtime support libraries, use s in the .lib name.
In this case, we are not linking statically to the runtime. so we can go with libcpprest140d_uwp_2_7.lib.
In future, if someone wants to add another version to link to the runtime statically, we can add _s to the name.
What do you think.
|
This change got merged to the development branch while I was merging something else. I will not revert it. Once we decide on the name, I can update the proj file with it. |
|
I have modified the static lib name to libcpprest140d_uwp_2_7.lib. The change is in the development branch. Please reopen the thread if you disagree with the naming convention. Thank you for contributing the changes. |
This is a very small addition with only a vcxproj for doing static lib compilation of Casablanca for UWP platform.
This produces safe to ignore warnings about static lib compilation with /ZW flag (it is safe because Casablanca does not expose public winrt types).
The motivation was to mix the benefits of using the native Windows http client (with its support for caching, prefetch and more), and the completeness of Casablanca Json serialization/deserialization (WinRT Json is somewhat basic, especially for long numbers handling), without paying for the whole Casablanca dll (saving bandwidth and memory consumption - especially in background agents).