Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Adding proxy support for token_from_code and token_from_refresh methods #1
Conversation
|
hey glukacsy Sorry for our delayed response. Thanks |
|
Hey, I have emailed you the CLA, thank you very much! |
kavyako
added a commit
that referenced
this pull request
Nov 5, 2015
Adding proxy support for token_from_code and token_from_refresh methods
AnyCPU
added a commit
to AnyCPU/cpprestsdk
that referenced
this pull request
Dec 22, 2015
xqp
pushed a commit
to xqp/cpprestsdk
that referenced
this pull request
Apr 5, 2018
FIX: Certificate Pinning Compilation on Linux
ghost
mentioned this pull request
This was referenced Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi,
I noticed that the token_from_code we are using in our project fails in an environment requiring proxy. The fundamental reason for this is that token_from_code under the hood instantiates a plain http_client without passing any configuration to it.
I was considering several designs how to solve this, but for simplicity I settled down on the idea of setting the proxy directly on the Oauth2 object.
Let me know if you have a different design in mind - in general I felt that the OAuth2 config is somewhat detached from the encapsulating HTTP config object. For example, if the OAuth2 config object knew about the parent HTTP config object it would be able to pull the proxy (and other things if needed) from the parent. I was just not sure about the design intent here and didn't want to propose a bigger structural change.
Regards,
Gergely