The Wayback Machine - https://web.archive.org/web/20200917224626/https://github.com/ParallelSSH/parallel-ssh/issues/125
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run commands over an interactive channel #125

Open
pkittenis opened this issue Jun 1, 2018 · 7 comments
Open

Run commands over an interactive channel #125

pkittenis opened this issue Jun 1, 2018 · 7 comments
Labels

Comments

@pkittenis
Copy link
Member

@pkittenis pkittenis commented Jun 1, 2018

Feature Request

  • Provide an alternative to run_command that uses a single interactive channel for all commands.

This provides a performance boost when running multiple commands one after another as opening/closing channels is the second most time consuming operation, after authentication.

Probably worth doing together with #114

@flavius

This comment has been minimized.

@flavius

This comment has been minimized.

@pkittenis
Copy link
Member Author

@pkittenis pkittenis commented Mar 23, 2019

Same channel cannot be reused for more than one execute command per SSH protocol. There are no examples because it is not possible.

The channel object is available on all clients as well as output objects, so clients can call channel.shell() and write commands manually to an interactive shell. This will not give separate output streams, that also needs to be handled in code. Providing an example of this is literally implementing this feature. PR welcome.

Regarding execute test, it is calling run_command which calls execute and that is what is being tested. What do you suggest the test should be doing?

The public API is fully documented and most developers are able to extend functionality when needed based on that information. Suggestions and PRs are always welcome.

@flavius

This comment has been minimized.

@pkittenis
Copy link
Member Author

@pkittenis pkittenis commented Mar 25, 2019

The tests are for testing implementation, not as user code examples.

There is function to open a channel, which execute takes as param. I'd expect most developers to be able to work with the documented API as-is, without specific examples for every function. PR welcome if you feel a specific example would be useful. Any further on this should be on the mail group, this is an issue for tracking feature implementation.

@flavius

This comment has been minimized.

@pkittenis
Copy link
Member Author

@pkittenis pkittenis commented Mar 25, 2019

See Code of Conduct. Abuse will not be tolerated.

As with all open source projects, work is done on a volunteer basis by people offering their free time. If there is something missing that someone wants and is sufficiently motivated to do they are more than welcome to.

All open source projects will say the same thing. Want something done quickly - roll up your sleeves and get going. Expect work for free and tell people with abusive language what to do.. good luck with that.

@pkittenis pkittenis changed the title Run commands over a single channel Run commands over an interactive channel Mar 27, 2019
@pkittenis pkittenis removed this from the 2.0.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.