The Wayback Machine - https://web.archive.org/web/20201206104402/https://github.com/angular/components/issues/21025
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-bug(checkbox): Documentation use "MAT_CHECKBOX_CLICK_ACTION" without notification of deprecation. When MAT_CHECKBOX_DEFAULT_OPTIONS should be used. Errors in v11. #21025

Open
Eddygn opened this issue Nov 12, 2020 · 2 comments · May be fixed by #21226

Comments

@Eddygn
Copy link

@Eddygn Eddygn commented Nov 12, 2020

The checkbox documentation page has a section about the usage of "MAT_CHECKBOX_CLICK_ACTION" to define the behavior on clicks.
It didn't provide any indication that this method is deprecated, nor that it was replaced with {provide: MAT_CHECKBOX_DEFAULT_OPTIONS, useValue: { clickAction: 'noop' } as MatCheckboxDefaultOptions }

Running a project after upgrading the Angular and Material package will produce an error.

Migration didn't touch this. I don't know if it was updated in earlier migration, since I've only added the provider a week ago, into v10 project. (no notice of deprecation anywhere I saw)

Affected documentation page:
https://material.angular.io/components/checkbox/overview

@lxandrexl
Copy link

@lxandrexl lxandrexl commented Nov 13, 2020

waiting solution :( i had same issue

@adhispace
Copy link

@adhispace adhispace commented Dec 5, 2020

Hi....can I take this...as this will be my first attempt to contribute. thanks

adhispace added a commit to adhispace/components that referenced this issue Dec 6, 2020
…eckbox

updates the documentation of customizing the default option of the checkbox.
the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10

fixes angular#21025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.