The Wayback Machine - https://web.archive.org/web/20210221144911/https://github.com/scikit-learn/scikit-learn/pull/18878
Skip to content

/ scikit-learn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update maintainers' guide to use new wheel builder system #18878

Merged
merged 7 commits into from Nov 26, 2020
Merged

DOC Update maintainers' guide to use new wheel builder system #18878

merged 7 commits into from Nov 26, 2020

Conversation

@alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Nov 20, 2020

Reference Issues/PRs

Closes #18776.

What does this implement/fix? Explain your changes.

This PR updates the maintainers' guide to use the Wheel builder workflow.

Any other comments?

CC @ogrisel.
@alfaro96
MNT Update maintainers' guide to use new wheel builder system
Unverified
This user has not uploaded their public key yet.
GPG key ID: 4D76EF9472F3A6D1 Learn about signing commits
Loading status checks…
a870814
@alfaro96
Copy link
Member Author

@alfaro96 alfaro96 commented Nov 20, 2020

Two side notes: We have to update this information when #18800 and #18801 get merged, which should simplify steps 3, 4 and 5.
@alfaro96
MNT Minor changes
Unverified
This user has not uploaded their public key yet.
GPG key ID: 4D76EF9472F3A6D1 Learn about signing commits
Loading status checks…
929fd18
@alfaro96 alfaro96 changed the title MNT Update maintainers' guide to use new wheel builder system DOC Update maintainers' guide to use new wheel builder system Nov 20, 2020
@alfaro96 alfaro96 added this to the 0.24 milestone Nov 23, 2020
@ogrisel
ogrisel approved these changes Nov 23, 2020
View changes
Copy link
Member

@ogrisel ogrisel left a comment

LGTM, just a few suggestions.

It's nice to see a PR that (legitimately) removes lines in the maintainers' documentation ;)
doc/developers/maintainer.rst Show resolved Hide resolved
doc/developers/maintainer.rst Outdated Show resolved Hide resolved
doc/developers/maintainer.rst Outdated Show resolved Hide resolved
doc/developers/maintainer.rst Outdated Show resolved Hide resolved
alfaro96 added 2 commits Nov 23, 2020
@alfaro96
CLN Apply suggested changes
Unverified
This user has not uploaded their public key yet.
GPG key ID: 4D76EF9472F3A6D1 Learn about signing commits
Loading status checks…
c42be2f
@alfaro96
CLN Apply suggested changes
Unverified
This user has not uploaded their public key yet.
GPG key ID: 4D76EF9472F3A6D1 Learn about signing commits
Loading status checks…
95bbf07
@ogrisel
ogrisel reviewed Nov 24, 2020
View changes
doc/developers/maintainer.rst Outdated Show resolved Hide resolved
@ogrisel
ogrisel reviewed Nov 24, 2020
View changes
doc/developers/maintainer.rst Outdated Show resolved Hide resolved
@ogrisel
Formatting fix
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
39333fd
@thomasjpfan
thomasjpfan reviewed Nov 24, 2020
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

The github checklist regarding

update dependencies and release tag at https://github.com/MacPython/scikit-learn-wheels

should be removed?
doc/developers/maintainer.rst Outdated Show resolved Hide resolved
@alfaro96
Copy link
Member Author

@alfaro96 alfaro96 commented Nov 25, 2020

The github checklist regarding

update dependencies and release tag at https://github.com/MacPython/scikit-learn-wheels

should be removed?

Since we are not longer using the MacPython/scikit-learn-wheels repository, I think that it should be removed.
@ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 26, 2020

Since we are not longer using the MacPython/scikit-learn-wheels repository, I think that it should be removed.

Yes.
@alfaro96
CLN Apply suggested changes
Unverified
This user has not uploaded their public key yet.
GPG key ID: 4D76EF9472F3A6D1 Learn about signing commits
ca204f0
@alfaro96
Copy link
Member Author

@alfaro96 alfaro96 commented Nov 26, 2020

I have applied the suggested changes 😉.
@alfaro96
Merge branch 'update_mainteiners_guide' of github.com:alfaro96/scikit…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 4D76EF9472F3A6D1 Learn about signing commits
Loading status checks…
2f0667f 
…-learn into update_mainteiners_guide
@thomasjpfan
thomasjpfan approved these changes Nov 26, 2020
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

LGTM
@thomasjpfan thomasjpfan merged commit eaa45c8 into scikit-learn:master Nov 26, 2020
26 checks passed
26 checks passed
triage
Details
Check build trigger
Details
Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}
Details
Source distribution
Details
Upload to Anaconda
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 697ceee...2f0667f
Details
codecov/project 98.18% (-0.01%) compared to 697ceee
Details
scikit-learn.scikit-learn Build #20201126.14 succeeded
Details
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
scikit-learn.scikit-learn (Linux py36_conda_openblas) Linux py36_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py36_ubuntu_atlas) Linux py36_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit) Linux32 py36_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit) Windows py36_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl) macOS pylatest_conda_forge_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp) macOS pylatest_conda_mkl_no_openmp succeeded
Details
@alfaro96 alfaro96 deleted the alfaro96:update_mainteiners_guide branch Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel

@thomasjpfan thomasjpfan

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
0.24
Linked issues

Successfully merging this pull request may close these issues.

Updade the maintainers' guide to use the new Wheel Builder github actions tool
3 participants
@alfaro96 @ogrisel @thomasjpfan