BUG: iloc.__setitem__ with dict value and mixed dtypes #38335
Merged
Conversation
| expected = df.copy() | ||
| rhs = {"x": 9, "y": 99} | ||
| df.loc[5] = rhs | ||
| expected.loc[5] = [9, 99] | ||
| tm.assert_frame_equal(df, expected) | ||
|
|
||
| # GH#38335 same thing, mixed dtypes |
jreback
Dec 8, 2020
Contributor
was this broken too? (or just iloc as indicated)?
is [] ok?
was this broken too? (or just iloc as indicated)?
is [] ok?
jbrockmendel
Dec 8, 2020
Author
Member
loc is broken too. setitem is OK i think.
loc is broken too. setitem is OK i think.
luckyvs1
added a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff