The Wayback Machine - https://web.archive.org/web/20201208142401/https://github.com/OAuthSwift/OAuthSwift/pull/620
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OAuthSwift pod version to 2.1.3 #620

Open
wants to merge 1 commit into
base: master
from

Conversation

@vgritsenko
Copy link

@vgritsenko vgritsenko commented Aug 14, 2020

This updates OAuthSwift version in OAuthSwift.podspec to 2.1.3, assuming this is the version to be used for the upcoming release.

OAuthSwift 2.1.2 has been already released and tagged, but since it was marked as 2.1.0 in podspec (https://github.com/OAuthSwift/OAuthSwift/blob/2.1.2/OAuthSwift.podspec) it can not now be used with CocoaPods. This can't be resolved without altering the tag, but, going forward, this commit ensures that upcoming 2.1.3 is going to have the right version in the OAuthSwift.podspec file and can be then published on CocoaPods.

Relates to issue: #615

@vgritsenko vgritsenko mentioned this pull request Aug 14, 2020
3 of 10 tasks complete
@phatblat
Copy link

@phatblat phatblat commented Sep 8, 2020

2.1.3 also needs to get pushed to CocoaPods trunk to finish the release.

@vgritsenko
Copy link
Author

@vgritsenko vgritsenko commented Sep 23, 2020

That is correct; after it is tagged.

@mesopelagique
Copy link

@mesopelagique mesopelagique commented Sep 23, 2020

just point out the head or a specific commit

@vgritsenko
Copy link
Author

@vgritsenko vgritsenko commented Sep 23, 2020

@mesopelagique You are not allowed to do that in a podspec. Your only option is to specify a version requirement. Setting it to >= 2.1.3 or anything like that will not work as this version is not posted to the repository. Additionally, both pod lib lint and pod repo push will fail for that pod.

https://guides.cocoapods.org/syntax/podspec.html#dependency

@phimage
Copy link
Member

@phimage phimage commented Sep 29, 2020

@vgritsenko you have a pod/framework with a pod spec dependant on OAuthSwift? is it published?

Podfile in final app allow to specify head, or commit

@vgritsenko
Copy link
Author

@vgritsenko vgritsenko commented Sep 29, 2020

@phimage Hey, yes, more than one, actually. They are in private repository.

@chadmoone
Copy link

@chadmoone chadmoone commented Oct 12, 2020

Any updates on this? Seems like a straightforward change. Anything I can do to help?

@pkordal
Copy link

@pkordal pkordal commented Nov 19, 2020

I would be also interested in having it updated. Anyone can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.