Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Failing linter checks on CI and locally on several files #2918
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
Pull requests should pass tests if their own specific changes pass
eldoc lintrun locally.Actual behavior
cider-connection.elandcider-doc.elfiles fail on CircleCI andcider-pkg.eladditionally fails locally (cider-pkg.eldoes not seem to be included in the checks run on CircleCISteps to reproduce the problem
Install eldev binary on your computer
https://github.com/doublep/eldev#installation
Clone the clojure-emacs/cider project
Run the lint command of eldev, from the root of the cloned clojure-emacs/cider project
Environment & Version information
CIDER version information
From
cider-version:CIDER 1.0.0snapshot (package: 20200930.1242)
From
cider-display-connection-info:Emacs version
GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2020-09-19
Operating system
Ubuntu Linux 20.04