Use better tempfile creation mechanism to avoid skip windows test #46222

walterddr · 2020-10-12T22:52:13Z

This is a follow up on #45917 - Previously we fixed test_serialization by

avoiding the usage of filename in torch.save/load;
kept one specific test to validate both file descriptor and filename code path for torch.save/load

However per @malfet 's comment we can also abstract out temp file creation step to support the last skipped unittest on windows.

cc @mruberry @VitalyFedyunin

sarahannali · 2020-10-13T02:00:38Z

Hi! Is this open for contribution?

mruberry · 2020-10-14T07:26:57Z

Hi! Is this open for contribution?

@sarahannali Yes, we would accept a PR fixing this.

DavidKatz-il · 2020-10-18T15:31:03Z

Hi @sarahannali
Are you working on a PR?

walterddr added good first issue module: tests triaged labels Oct 12, 2020

walterddr changed the title ~~Use better tempfile creation mechanism for windows test~~ Use better tempfile creation mechanism to avoid skip windows test Oct 12, 2020

Nov	DEC	Jan
	08
2019	2020	2021

pytorch / pytorch

Use better tempfile creation mechanism to avoid skip windows test #46222

Use better tempfile creation mechanism to avoid skip windows test #46222

walterddr commented Oct 12, 2020 •

edited by pytorch-probot bot

sarahannali commented Oct 13, 2020

mruberry commented Oct 14, 2020

DavidKatz-il commented Oct 18, 2020

pytorch / pytorch

Join GitHub today

GitHub is where the world builds software

Use better tempfile creation mechanism to avoid skip windows test #46222

Use better tempfile creation mechanism to avoid skip windows test #46222

Comments

walterddr commented Oct 12, 2020 • edited by pytorch-probot bot

sarahannali commented Oct 13, 2020

mruberry commented Oct 14, 2020

DavidKatz-il commented Oct 18, 2020

Essential cookies

Always active

Analytics cookies

walterddr commented Oct 12, 2020 •

edited by pytorch-probot bot