Fixup labels on reversed axes when ticklabelmode is set to period #5060
Conversation
Nice, good catch! It'd be nice to include jasmine tests for ^^ both forward and reversed, with the original range shifted in something like 6-hour increments - so ranges:
And just check that the tick text we get in each case is as expected. Something like that should cover all the related cases, I'd think. |
@alexcjohnson in order not to intersect with #5065, I need to merge this PR and work on the fix for #5065 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Follow up of implementing #4911 by #4993.
Fixes the labels on reversed axes the bug introduced in 83f5cdd.
@plotly/plotly_js
The text was updated successfully, but these errors were encountered: