The Wayback Machine - https://web.archive.org/web/20220519174502/https://github.com/tensorflow/tfjs/pull/4382
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e custom bundle test for universal sentence encoder #4382

Merged
merged 4 commits into from Dec 14, 2020

Conversation

tafsiri
Copy link
Member

@tafsiri tafsiri commented Dec 10, 2020

Uses webgl as the backend.

This also restores the other custom bundle test to run in nightly.

We can merge after 2.8 is released.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@tafsiri tafsiri requested a review from lina128 Dec 10, 2020
@tafsiri tafsiri marked this pull request as ready for review Dec 10, 2020
@tafsiri
Copy link
Member Author

@tafsiri tafsiri commented Dec 10, 2020

I'll also be adding the approach used to profile the app.ts program to the other models in a followup PR. It will make it easier to update the kernels should they ever change in future. Having that as a flag in the test makes its quite straightforward to see what kernels should be executed.

Copy link
Collaborator

@lina128 lina128 left a comment

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128)

@lina128 lina128 requested review from mattsoulanille and lina128 Dec 10, 2020
@tafsiri tafsiri merged commit fa3d588 into master Dec 14, 2020
2 checks passed
@tafsiri tafsiri deleted the use-custom-e2e-test branch Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants