Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Update guarantees of unwinding past an extern "C" function #887
Conversation
The current docs say it will abort, however that behavior was actually reverted in rust-lang/rust#48445 and is not what currently happens in stable.
|
Thanks for the PR! |
| > **Note**: Currently, in nightly `rustc` the LLVM backend aborts the process | ||
| > by executing an illegal instruction. However, this is not the behavior in stable. |
Comment on lines
+184
to
+185
ehuss
Sep 28, 2020
Collaborator
We generally don't include notes about specific versions of the rustc compiler in the reference. I'm also not sure what this is referring to, since it no longer aborts on unwind.
We generally don't include notes about specific versions of the rustc compiler in the reference. I'm also not sure what this is referring to, since it no longer aborts on unwind.
| with such ABIs causes the process to abort. | ||
| Functions with an ABI that differs from `"Rust"` do not support unwinding in | ||
| the exact same way that Rust does. Therefore, unwinding past the end of | ||
| functions with such ABIs results in undefined behavior, and will differ between |
ehuss
Sep 28, 2020
Collaborator
Can you link undefined behavior to behavior-considered-undefined.md?
Can you link undefined behavior to behavior-considered-undefined.md?
| Functions with an ABI that differs from `"Rust"` do not support unwinding in | ||
| the exact same way that Rust does. Therefore, unwinding past the end of | ||
| functions with such ABIs results in undefined behavior, and will differ between | ||
| platforms and compiler editions. If you cannot guarantee this will not happen, |
ehuss
Sep 28, 2020
Collaborator
I'm not sure what "compiler editions" means here. "Edition" has a specific meaning in Rust, and I don't think that is what is being referred to here. I think it would be fine to end the sentence at "undefined behavior", with the link leading the reader to understanding what that means.
I'm not sure what "compiler editions" means here. "Edition" has a specific meaning in Rust, and I don't think that is what is being referred to here. I think it would be fine to end the sentence at "undefined behavior", with the link leading the reader to understanding what that means.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As prompted by discussion in rust-lang/rust#52652
The current docs say it will abort, however that behavior was actually reverted in rust-lang/rust#48445 and is not what currently happens in stable.