COLLECTED BY

Organization: Archive Team

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

History is littered with hundreds of conflicts over the future of a community, group, location or business that were "resolved" when one of the parties stepped ahead and destroyed what was there. With the original point of contention destroyed, the debates would fall to the wayside. Archive Team believes that by duplicated condemned data, the conversation and debate can continue, as well as the richness and insight gained by keeping the materials. Our projects have ranged in size from a single volunteer downloading the data to a small-but-critical site, to over 100 volunteers stepping forward to acquire terabytes of user-created data to save for future generations.

The main site for Archive Team is at archiveteam.org and contains up to the date information on various projects, manifestos, plans and walkthroughs.

This collection contains the output of many Archive Team projects, both ongoing and completed. Thanks to the generous providing of disk space by the Internet Archive, multi-terabyte datasets can be made available, as well as in use by the Wayback Machine, providing a path back to lost websites and work.

Our collection has grown to the point of having sub-collections for the type of data we acquire. If you are seeking to browse the contents of these collections, the Wayback Machine is the best first stop. Otherwise, you are free to dig into the stacks to see what you may find.

The Archive Team Panic Downloads are full pulldowns of currently extant websites, meant to serve as emergency backups for needed sites that are in danger of closing, or which will be missed dearly if suddenly lost due to hard drive crashes or server failures.

Collection: Archive Team: The Github Hitrub

This collection is a set of Github repository archives from two major sets: A panic grab upon the acquisition by Microsoft, and a larger, ongoing set of Pretty Much Everything.

TIMESTAMPS

The Wayback Machine - https://web.archive.org/web/20201228172938/https://github.com/rust-lang/reference/pull/914

rust-lang / reference

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document array expression with a const. #914

Open

ehuss wants to merge 3 commits into rust-lang:master from ehuss:array-const

Collaborator

ehuss commented Dec 22, 2020

Documentation for rust-lang/rust#79270.

I did not include any details about drop behavior with [a; 0], as it seems like rust-lang/rust#74836 is unresolved, though I can add that if desired. (I'm not sure if that would go in the array-expr chapter, or the destructor chapter.)

Collaborator Author

ehuss commented Dec 22, 2020

@RalfJung Sorry, bugging you to review another one.

Member

RalfJung commented Dec 26, 2020

This sounds correct. However, do you want to mention the subtleties around drop? See rust-lang/rust#79270 (comment) and the surrounding discussion.

Collaborator Author

ehuss commented Dec 26, 2020

Hm, yea, as mentioned in the description, I intentionally left that out because I was uncertain what to say. Since rust-lang/rust#74836 is unresolved, should it document that [non_const_expr; 0] evaluates once and then drops, and then include a note that this is not working as intended? Or just leave that part out completely and only say [CONST; 0] does not evaluate CONST (it seems a little weird to say that without contrasting it with the non-const example). Also, would you recommend putting that in the Destructors chapter, the Array Expression chapter, the Constant Evaluation chapter, or maybe in multiple locations?

Collaborator

Havvy commented Dec 26, 2020

I would document it how it is now ([CONST; 0]) does not evaluate CONST), but include a warning directly after contrasting this behavior with the non-const example.

Member

RalfJung commented Dec 26, 2020

I would document it how it is now ([CONST; 0]) does not evaluate CONST), but include a warning directly after contrasting this behavior with the non-const example.

Sounds good.

As to where to put this... I have little idea about the structure of the reference, so I'll leave that up to you. I would not document the same thing in multiple places, but adding cross-references might be a good idea.

Collaborator Author

ehuss commented Dec 27, 2020

OK, I included a note on the [a; 0] behavior. I waffled a little on whether or not to note the bug. We talked about the policy a little bit in #599, and it seemed like the consensus is that it doesn't hurt to include the occasional note about a bug. I can remove it whenever rust-lang/rust#74836 is closed.

RalfJung reviewed

src/expressions/array-expr.md Outdated

  
        greater than 1 then this requires that the type of `a` is

        [`Copy`](../special-types-and-traits.md#copy), or `a` must be a path to a

        constant item.

        constant item. When `b` evaluates to 0, the expression `a` is evaluated once

RalfJung Dec 27, 2020
Member

"the expression `a` is evaluated once" is always true for non-constant-items. So I think it is a bit strange to make `0` sound like a special case here.

I'd describe this (probably in a separate paragraph) as:

for constant items, the expression is instantiated `b` times. (So if `b == 0`, it is not instantiated at all.)

for other `a`, the expression is evaluated exactly once (and then the result is copied as needed).

ehuss Dec 28, 2020
Author Collaborator

Oh, that makes sense and is much clearer to me now. Thanks for your patience!

ehuss added 3 commits


          Move links to bottom of the file.

8027bc8


          Document array expression with a const.

e031b14


          Document [a; 0] behavior.

a2e5a14

ehuss force-pushed the ehuss:array-const branch from 3d5a774 to a2e5a14

Member

RalfJung commented Dec 28, 2020

LGTM. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.