The Wayback Machine - https://web.archive.org/web/20210104135955/https://github.com/bazelbuild/rules_python/pull/198
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing METADATA parsing via pkginfo #198

Open
wants to merge 3 commits into
base: master
from

Conversation

@mdvorsky
Copy link

@mdvorsky mdvorsky commented Jun 29, 2019

Replaces the incomplete METADATA parsing with pkginfo. Adds tests using real-world packages.

Fixes #102

@rogerhub
Copy link

@rogerhub rogerhub commented Aug 1, 2019

@brandjon Can you take a look? I think this patch is an important fix.

@mdvorsky
Copy link
Author

@mdvorsky mdvorsky commented Oct 3, 2019

@brandjon @lberki any thoughts at all? I realize my fix may not be the preferred way to address this, but I'd love to see this addressed one way or another, so that we can get rid of our local fork of rules_python.

@cristifalcas
Copy link

@cristifalcas cristifalcas commented Oct 10, 2019

Hi @brandjon. Please let us know if this project is maintained, or we should move to something else. There are multiple PRs and issues that are not answered for months.

Importing pip packages doesn't work, using python3 is even in a worst state.

@cgordoncarroll
Copy link

@cgordoncarroll cgordoncarroll commented Dec 10, 2019

Any updates on this pull request? Using Bazel in conjunction with python3/pip seems pretty painful without this. @brandjon

@ppodolsky
Copy link

@ppodolsky ppodolsky commented Dec 20, 2019

I second @cgordoncarroll. Is there a way we could help to push this PR forward?

@smamessier
Copy link

@smamessier smamessier commented Mar 10, 2020

Would be very interested in this being merged as well. Trying to use Bazel with Python3 deps.

@thundergolfer
Copy link
Collaborator

@thundergolfer thundergolfer commented Mar 10, 2020

@smamessier

Have you tried any of these?

They all support Python 3. We are using the 1st with Python 3.6 at work. It was created after bazelbuild/rules_python just wouldn't work for us.

@smamessier
Copy link

@smamessier smamessier commented Mar 25, 2020

@thundergolfer Thanks I ended up using https://github.com/dillon-giacoppo/rules_python_external and it works perfectly.

@googlebot
Copy link

@googlebot googlebot commented Apr 14, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mdvorsky
Copy link
Author

@mdvorsky mdvorsky commented Apr 21, 2020

@googlebot I fixed it.

@mdvorsky mdvorsky force-pushed the merlon:marian/whl_fix branch from ab4bbe9 to 26b56c5 Apr 29, 2020
@googlebot
Copy link

@googlebot googlebot commented Apr 29, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jakebiesinger-onduo
Copy link

@jakebiesinger-onduo jakebiesinger-onduo commented Jun 18, 2020

👋 1-year anniversary for this PR is coming up. Any chance we could get it merged?

@mdvorsky
Copy link
Author

@mdvorsky mdvorsky commented Jun 22, 2020

Copy link
Collaborator

@andyscott andyscott left a comment

My only context for this code change is a close reading of the diff (unfortunately 😢 ), but with that in mind, this looks good to me.

@mdvorsky
Copy link
Author

@mdvorsky mdvorsky commented Jun 24, 2020

Thanks a lot @andyscott! Would you like me to do anything else here? (The build of your merge failed because of an unrelated issue already fixed at head, afaict).

@googlebot
Copy link

@googlebot googlebot commented Aug 1, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 1, 2020
@mdvorsky mdvorsky force-pushed the merlon:marian/whl_fix branch from ba26361 to ff884c1 Aug 1, 2020
@googlebot
Copy link

@googlebot googlebot commented Aug 1, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 1, 2020
@mdvorsky
Copy link
Author

@mdvorsky mdvorsky commented Aug 1, 2020

Hi! @thundergolfer @andyscott I removed the .par files from the PR, and squashed the commits. Is there anything else I should do here? Thank you!

mdvorsky added 2 commits Aug 4, 2020
@horkyada
Copy link

@horkyada horkyada commented Oct 12, 2020

Hi rules_python folks. Is there any chance this gets merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

You can’t perform that action at this time.