The Wayback Machine - https://web.archive.org/web/20210104141417/https://github.com/bazelbuild/rules_python/pull/344
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing windows CI #344

Open
wants to merge 1 commit into
base: master
from
Open

Add missing windows CI #344

wants to merge 1 commit into from

Conversation

@alexeagle
Copy link
Collaborator

@alexeagle alexeagle commented Jul 19, 2020

Fixes #2 (if we can get it green)

@thundergolfer
Copy link
Collaborator

@thundergolfer thundergolfer commented Jul 20, 2020

@thundergolfer
Copy link
Collaborator

@thundergolfer thundergolfer commented Jul 20, 2020

There's a whole lot of Windows specific logic in https://github.com/bazelbuild/bazel/blob/1a0852199d05bef95fcceaa1ef244c36d393bfb0/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java that ends up creating the <target_name>.exe that is in this case compiler.exe.

Somewhere in there a non-UTF-8 char is being introduced, or the whole file is actually just binary and not a text-based bash file like in Unix.

I'd say I'd be better to address this issue be replacing the .par files, like we did in rules_python_external.

@alexeagle
Copy link
Collaborator Author

@alexeagle alexeagle commented Jul 20, 2020

Agreed that the best path forward here is to upstream rules_python_external approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.