Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Remove the rules_python_external README #391
Open
Conversation
|
LGTM. Up to your discretion to add the chunks I commented on to the top level README |
| # If you need to depend on the wheel dists themselves, for instance to pass them | ||
| # to some other packaging tool, you can get a handle to them with the whl_requirement macro. | ||
| filegroup( | ||
| name = "whl_files", | ||
| data = [ | ||
| whl_requirement("boto3"), | ||
| ] | ||
| ) |
Comment on lines
-77
to
-84
hrfuller
Dec 21, 2020
Collaborator
Might be good to document this in the packaging rules.
Might be good to document this in the packaging rules.
thundergolfer
Dec 22, 2020
Author
Collaborator
I'll add a sub-section for it 👍
I'll add a sub-section for it
| load("@rules_python_external//:defs.bzl", "pip_install") | ||
| pip_install( | ||
| name = "py_deps", | ||
| requirements = "//:requirements.txt", | ||
| # (Optional) You can provide a python interpreter (by path): | ||
| python_interpreter = "/usr/bin/python3.8", | ||
| # (Optional) Alternatively you can provide an in-build python interpreter, that is available as a Bazel target. | ||
| # This overrides `python_interpreter`. | ||
| # Note: You need to set up the interpreter target beforehand (not shown here). Please see the `example` folder for further details. | ||
| #python_interpreter_target = "@python_interpreter//:python_bin", | ||
| ) |
Comment on lines
-51
to
-61
hrfuller
Dec 21, 2020
•
Collaborator
This example still seems useful to document the python_interpreter[_target] arguments.
This example still seems useful to document the python_interpreter[_target] arguments.
thundergolfer
Dec 22, 2020
Author
Collaborator
Agreed. It documented in the README but in words not code examples.
Agreed. It documented in the README but in words not code examples.
thundergolfer
added a commit
that referenced
this pull request
Jan 3, 2021
…external README into root README. ref: #391
…external README into root README. ref: #391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
Description
This
READMEwas carried over during the merge ofrules_python_external, and it has info that's duplicating and sometimes contradictory of the documentation in the rootREADME. I'd favour just removing it.If there's anything in this
READMEthat you think should remain in the repo, I can pull it out and put it in the rootREADMEunder "Using the packaging rules".Does this PR introduce a breaking change?