Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
UPDATE for Vue3 ( = vuex 4.x, vue-router 4.x) #100
Conversation
| @@ -44,7 +44,7 @@ export function sync( | |||
| // sync router on store change | |||
| const storeUnwatch = store.watch( | |||
| @@ -36,8 +36,8 @@ | |||
| }, | |||
| "homepage": "https://github.com/vuejs/vuex-router-sync#readme", | |||
| "peerDependencies": { | |||
| "vue-router": "^3.0.0", | |||
| "vuex": "^3.0.0" | |||
| "vue-router": "^4.0.0-rc.5", | |||
Akryum
Dec 30, 2020
Member
Maybe use stable version range to keep it clean?
Maybe use stable version range to keep it clean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
To use vuex-router-sync in Vue 3.x, I updated vue, vuex and vue-router!
Changed src and test,
currently the test is not perfect, help...😭 About vue-routers's afterEachTo mutate latest route info, this package using vue-router'safterEachfunction.But vue-router v4.x only export add function, and doesn't export any list that registered afterEach.I want to testunsynccorrectly remove router's afterEach hook, but I have no idea.About vuex's watchTo sync router on store change, this package using vuex'swatchfunctionBut I can't find a way to confirm what is registered in watch hooks!I want to testunsynccorrectly remove vuex's watch hook, but I have no idea...About unsync test