Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix: clone route outside of mutation #93
Conversation
|
Hi thanks for the PR and sorry for the late response. Could you provide the reproduction code for this? |
|
Closing due to inactivity. |
|
@kiaking Sorry for the late reply. I've created a demo here. Basically anything that attempts to log or persist mutations can be tripped up by the payload of the The simplest way to create an error is with a mutation logger which attempts to stringify the payload. If you attach vue-devtools to the page and enable the new vuex backend, you'll also get errors there as it attempts to clone the mutation. The cloning logic there is different and it doesn't always throw an error when cloning a component. |
|
@cjpearson Ah, thank you so much for checking in. OK now I see the problem here. Would it be possible for you add a test for this? |
|
Yeah I can take a crack at that. |
|
@cjpearson Thanks a lot! In that case, please rebase the branch to the latest |
This change moves to call to
cloneRouteoutside of the mutation and passes the already-cloned route as the payload. It fixes some console errors that might occur when the vue-devtools extension tries to clone the mutation payload. In my case there were errors when it attempted to clone components within thematchedarray of the route.