Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Use headersSent instead of _header #129
Open
Conversation
|
Hm, I just noticed that I branched from my other changes. Should I remove those changes from this PR? |
maritz
changed the title
|
Hi @maritz I can try to cut them out myself during the merge, but if you can remove them, that may be good especially in case something else changes (either in the other PR or between that PR merging and the major release to include this change). |
dougwilson
force-pushed the
expressjs:master
branch
3 times, most recently
from
d7bb81b
to
cd957aa
maritz
force-pushed the
maritz:change/use_headersSent_instead_of__header
branch
from
de4f632
to
24a6740
|
@dougwilson I rebased and cut out the extra commits. |
maritz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As discussed in #127 this PR now includes the changes that do break node v0.8 and has tests.
I did not remove the travis config for v0.8 since I'm not sure that's something that should be in a PR.