feat: support brotli #150
feat: support brotli #150
Conversation
Thank you so much for volunteering to help get this feature a reality! From reviewing the PR, it looks like the following things still need to be done, so I'm listing so you have something concrete to work through: (1) There is no documentation around this, specifically all the options like (2) There are no tests added. This is picked up just by the coverage CI check, since the new line for I hope this helps! Thanks for picking this up! |
@dougwilson Thank you so much for the quick and detailed review. For the
For the test, since brotli is only supported in node 11.7, can we add it in travis ? |
Friendly reminder @dougwilson |
Thanks for working on this @clarkdo! For what it's worth, in my testing the content negotiation provided by accepts (which uses negotiator under the hood) will choose Working off of your branch I was able to get Brotli working end-to-end by swapping out the content negotiation from "accepts" to "accept": https://www.npmjs.com/package/accept, and fixing a couple typos. I'm happy to contribute those changes if we want to prefer |
Hi there I would really like to serve my static files with brotli. So are there any plans when this might be merged or can I help out somewhere? Greetings Sven |
Any progress? |
No description provided.