Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
add option to specify available encodings #27
Conversation
|
+1 |
| @@ -157,7 +158,7 @@ function compression(options) { | |||
|
|
|||
| // compression method | |||
| var accept = accepts(req) | |||
| var method = accept.encoding(['gzip', 'deflate', 'identity']) | |||
| var method = accept.encoding(available) | |||
|
|
|||
| // negotiation failed | |||
| if (!method || method === 'identity') { | |||
Fishrock123
Jan 26, 2015
Member
Correct me if I'm wrong, but I think it always needs to have the identity fallback.
Correct me if I'm wrong, but I think it always needs to have the identity fallback.
hex7c0
Jan 26, 2015
right
if you want disable deflate algorithm, you should use ['gzip', 'identity']
right
if you want disable deflate algorithm, you should use ['gzip', 'identity']
dougwilson
Jan 26, 2015
Member
Right. I'm not sure if the interface should make the user include identity
Right. I'm not sure if the interface should make the user include identity
hex7c0
Jan 26, 2015
before force identity, people should check the presence of their algorithms inside this module
worst case? ciao like a new superpowerful algorithm :)
['ciao', 'identity'] as option
ab -v 4 -H "Accept-Encoding: ciao" -c 1 -n 1 127.0.0.1:3000/with_compression
LOG: header received:
HTTP/1.1 200 OK
Content-Type: text/plain
Vary: Accept-Encoding
Content-Encoding: ciao
Date: Mon, 26 Jan 2015 18:59:20 GMT
Connection: close
sent with deflate algorithm https://github.com/expressjs/compression/blob/master/index.js#L172
before force identity, people should check the presence of their algorithms inside this module
worst case? ciao like a new superpowerful algorithm :)
['ciao', 'identity'] as option
ab -v 4 -H "Accept-Encoding: ciao" -c 1 -n 1 127.0.0.1:3000/with_compression
LOG: header received:
HTTP/1.1 200 OK
Content-Type: text/plain
Vary: Accept-Encoding
Content-Encoding: ciao
Date: Mon, 26 Jan 2015 18:59:20 GMT
Connection: closesent with deflate algorithm https://github.com/expressjs/compression/blob/master/index.js#L172
dougwilson
Jan 26, 2015
Member
@hex7c0 , right, that is another case that needs to be fixed and why this PR hasn't been merged just yet :)
@hex7c0 , right, that is another case that needs to be fixed and why this PR hasn't been merged just yet :)
dougwilson
force-pushed the
expressjs:master
branch
3 times, most recently
from
d7bb81b
to
cd957aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
closes #25