COLLECTED BY

Organization: Archive Team

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

History is littered with hundreds of conflicts over the future of a community, group, location or business that were "resolved" when one of the parties stepped ahead and destroyed what was there. With the original point of contention destroyed, the debates would fall to the wayside. Archive Team believes that by duplicated condemned data, the conversation and debate can continue, as well as the richness and insight gained by keeping the materials. Our projects have ranged in size from a single volunteer downloading the data to a small-but-critical site, to over 100 volunteers stepping forward to acquire terabytes of user-created data to save for future generations.

The main site for Archive Team is at archiveteam.org and contains up to the date information on various projects, manifestos, plans and walkthroughs.

This collection contains the output of many Archive Team projects, both ongoing and completed. Thanks to the generous providing of disk space by the Internet Archive, multi-terabyte datasets can be made available, as well as in use by the Wayback Machine, providing a path back to lost websites and work.

Our collection has grown to the point of having sub-collections for the type of data we acquire. If you are seeking to browse the contents of these collections, the Wayback Machine is the best first stop. Otherwise, you are free to dig into the stacks to see what you may find.

The Archive Team Panic Downloads are full pulldowns of currently extant websites, meant to serve as emergency backups for needed sites that are in danger of closing, or which will be missed dearly if suddenly lost due to hard drive crashes or server failures.

Collection: Archive Team: The Github Hitrub

This collection is a set of Github repository archives from two major sets: A panic grab upon the acquisition by Microsoft, and a larger, ongoing set of Pretty Much Everything.

TIMESTAMPS

The Wayback Machine - https://web.archive.org/web/20210116090324/https://github.com/codecasts/laravel-jwt/pull/45

codecasts / laravel-jwt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 5.7 #45

Open

jonagoldman wants to merge 5 commits into codecasts:develop from unknown repository

Contributor

jonagoldman commented Nov 23, 2018 •

edited

The __construct method of Auth events has a new $guard argument in Laravel 5.7:

public function __construct($guard, $user, $remember)

See: https://laravel.com/docs/5.7/upgrade

We now need to pass the guard name, otherwise an error will brake the application. This PR fixes that. It will work with Laravel >= 5.7

jonagoldman added 4 commits


          fix middleware group match by catching exception

036d641


          fix guard creation and events fire for laravel 5.7

c04095a


          fix guard return

b3ae633


          use original guard check wrapped inside try catch

bed0b0a

jonagoldman mentioned this pull request

BindingResolutionException #6

Open

Anticom reviewed

src/Auth/Guard.php Outdated

  
                    $this->events->dispatch(new Attempting(

                        $credentials, false

                    ));

                    $this->events->dispatch(new Attempting('jwt', $credentials, false));

Anticom Nov 26, 2018

Iirc there's `$this->name` available. Shouldn't this one be used? This also applies to `Failed` and `Login`.

Anticom commented Nov 26, 2018

Please see https://github.com/codecasts/laravel-jwt/pull/45/files#r236394315


          use guard $name property instead of hardcoded string

783b811

Contributor Author

jonagoldman commented Nov 26, 2018

@Anticom you are right, my mistake. fixed.

Anticom commented Nov 27, 2018 •

edited

Looks good to me now. However still not an laravel expert ;)

Edit
One more thing.
Looking at laravel/framework/src/Illuminate/Auth/SessionGuard.php the method getRequest is implemented w/o using an application reference but rather like so:

  public function getRequest() {
    return $this->request ?: Request::createFromGlobals();
  }

As far as i can tell this is the only reason, why $app would be injected into the guard and #6 is talking about the injector having issues with that. I don't know enough about the internals of laravel's DI but changing this in src/Auth/Guard.php might help with the issue.
Lastly not sure whether this should belong in this PR tho.

Contributor Author

jonagoldman commented Nov 29, 2018 •

edited

@Anticom if you look at Laravel's SessionGuard.php you will see that the referenced Request class is actually Symfony\Component\HttpFoundation\Request and not Illuminate\Http\Request:

https://github.com/laravel/framework/blob/453317f5b2c93b5312392f36e0574d5be9755d0e/src/Illuminate/Auth/SessionGuard.php#L13

So we are talking about two different things here.

This package depends on Laravel and not on Symfony components, so getting the request directly from the Laravel application seems fine to me.
Also, I don't know if this is related to issue #6 as I don't have that problem.

Finally I don't know what do you mean by whether this should belong in this PR, all the changes I make to my laravel-5.7 branch will be automatically added to this PR, so I';m waiting for @hernandev to take a look at it and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.