The Wayback Machine - https://web.archive.org/web/20210124105418/https://github.com/sql-js/sql.js/issues/361
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql.js.org website #361

Open
brodybits opened this issue Mar 4, 2020 · 13 comments
Open

sql.js.org website #361

brodybits opened this issue Mar 4, 2020 · 13 comments
Assignees
Labels

Comments

@brodybits
Copy link
Contributor

@brodybits brodybits commented Mar 4, 2020

js-org/js.org#3775

Would definitely be nicer than sql-js.github.io/...

I would be happy to help with this if needed.

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 4, 2020

Yes, work on the website would be welcome, thank you for proposing your help @brodybits !

I think there is quite some work:

  • cleaning up the website files that are currently mixed with the source files, and creating a CNAME file for js.org
  • have a single command to build the website (including the jsdoc documentation)
  • add an action to .github/workflows to run that command on CI and push the result to the gh-pages branch

Once we have that, we can open a PR to js.org to have sql.js.org.

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 11, 2020

I created a demonstration of how to integrate sql.js with webpack at https://github.com/sql-js/react-sqljs-demo

You can use that, and move it into gh-pages if you want, @brodybits

@brodybits
Copy link
Contributor Author

@brodybits brodybits commented Mar 11, 2020

Hi @lovasoa that demo looks really nice. A couple questions & ideas:

  • I would favor making the demo under MIT license, which should be more consistent with React, SQL.js, and so many other packages in the JS ecosystem.
  • Nicer multi-line editor, ideally with SQL highlighting (should be pretty easy to find an existing solution that can work with React)
lovasoa added a commit to sql-js/react-sqljs-demo that referenced this issue Mar 11, 2020
@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 11, 2020

I updated the license.

As for the second change... Maybe there should be two demos ?
One that is full-featured and replaces the old https://sql-js.github.io/sql.js/examples/GUI/
and one that is very short and well-commented that can be used as a template and a reference for how to integrate sql.js with a build system. I would like users to be able to go over the sources of this demo in <5mins.

@brodybits
Copy link
Contributor Author

@brodybits brodybits commented Mar 11, 2020

one that is very short and well-commented
[...]
I would like users to be able to go over the sources of this demo in <5mins.

Yes, maybe with some kind of a "use this template" button like here: https://help.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-from-a-template

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 11, 2020

maybe with some kind of a "use this template" button

I did that already.

image

@kaizhu256
Copy link
Member

@kaizhu256 kaizhu256 commented Mar 11, 2020

nice work on react-demo.

but are we gonna use react for full-feature demo? i prefer it stays vanilla-js so people like me can clone-and-modify it w/o any extra tooling.

also have plans to add import/export csv buttons to the full-feature demo (and perhaps store/load buttons for indexeddb).

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 11, 2020

I think a majority of frontend project these days use some sort of tooling. But nothing is preventing us from having many different demos, demonstrating different usages. One of them can be one where everything is done by hand.

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 31, 2020

@brodybits : are you still working on this?

@brodybits
Copy link
Contributor Author

@brodybits brodybits commented Mar 31, 2020

Maybe later this week, if nobody else wants to take it on. My apologies.

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Mar 31, 2020

No problem, you have no obligations here. If you change your mind, just tell me and I'll assign this to myself.

@brodybits brodybits removed their assignment Mar 31, 2020
@brodybits
Copy link
Contributor Author

@brodybits brodybits commented Mar 31, 2020

👍thanks!

@lovasoa
Copy link
Member

@lovasoa lovasoa commented Oct 12, 2020

we're live on https://sql.js.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants