The Wayback Machine - https://web.archive.org/web/20200430202140/https://github.com/ReactiveX/RxJava/pull/6711
Skip to content

/ RxJava

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Upgrade to Gradle 5.6.4 #6711

Merged
merged 1 commit into from Nov 12, 2019
Merged

3.x: Upgrade to Gradle 5.6.4 #6711

merged 1 commit into from Nov 12, 2019

Conversation

@akarnokd
Copy link
Member

akarnokd commented Nov 12, 2019

There seem to be a couple of regressions with Gradle 5.6 and 5.6.1 that broke Eclipse for me today when I switched between 2.x (uses 4.3.1) and 3.x branches (5.6) that I couldn't resolve by clean import either. All my 5.6.2 and 6.0 work fine so there could be something in 5.6 badly interacting with the Buildship Eclipse plugin handling the Gradle integration.

https://github.com/gradle/gradle/releases/tag/v5.6.2
@akarnokd
3.x: Upgrade to Gradle 5.6.4
Loading status checks…
54ba3f2
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #6711 into 3.x will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6711      +/-   ##
============================================
- Coverage     98.19%   98.11%   -0.09%     
+ Complexity     6192     6189       -3     
============================================
  Files           677      677              
  Lines         44657    44657              
  Branches       6170     6170              
============================================
- Hits          43853    43815      -38     
- Misses          284      304      +20     
- Partials        520      538      +18
Impacted Files Coverage Δ Complexity Δ
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...java3/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 91.54% <0%> (-3.53%) 2% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-2.71%) 2% <0%> (ø)
...rxjava3/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 93.65% <0%> (-2.39%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...rxjava3/internal/schedulers/ExecutorScheduler.java 97% <0%> (-1.5%) 10% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999ee67...54ba3f2. Read the comment docs.
@vanniktech
vanniktech approved these changes Nov 12, 2019
View changes
@akarnokd akarnokd merged commit e4c4903 into ReactiveX:3.x Nov 12, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 999ee67...54ba3f2
Details
codecov/project 98.11% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd:Gradle564 branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech

Assignees
No one assigned
Labels
3.x Build
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@akarnokd @vanniktech
You can’t perform that action at this time.