The Wayback Machine - https://web.archive.org/web/20201126012920/https://github.com/TheAlgorithms/Python/pull/3865
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create slowsort.py #3865

Open
wants to merge 9 commits into
base: master
from
Open

Create slowsort.py #3865

wants to merge 9 commits into from
+61 −0

Conversation

@MrGeek1337
Copy link

@MrGeek1337 MrGeek1337 commented Nov 5, 2020 •
edited

added slowsort algorithm implementation to sorts

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@MrGeek1337
Create slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa8edea 
added slowsort algorithm implementation to sorts
@MrGeek1337 MrGeek1337 requested a review from mateuszz0000 as a code owner Nov 5, 2020
MrGeek1337 added 5 commits Nov 5, 2020
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49d85dd
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a4c2c74
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
483ef06
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5d2fc3f
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
35e95a5
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

I believe this algorithm has been already added here.
@MrGeek1337
Copy link
Author

@MrGeek1337 MrGeek1337 commented Nov 5, 2020

The algorithm you linked to is Bogosort, which is an entirely different algorithm, but it is also called Slowsort at times.
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

Oh, ok. Sorry for the misunderstanding
@MrGeek1337
Copy link
Author

@MrGeek1337 MrGeek1337 commented Nov 5, 2020 •
edited

No worries, you could look at the code and notice the differences, you could also check Bogosort and Slowsort at Wikipedia.
@mrmaxguns
mrmaxguns reviewed Nov 5, 2020
View changes
sorts/slowsort.py Outdated Show resolved Hide resolved
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
18bf22c
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

Isort failed, looks like you need to reorder the imports
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a1f6d6e
@MrGeek1337
Copy link
Author

@MrGeek1337 MrGeek1337 commented Nov 5, 2020

Done!
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

Thanks for contributing to open source 👍

@cclauss could you review and merge this pull request?
@NumberPiOso
NumberPiOso suggested changes Nov 12, 2020
View changes
sorts/slowsort.py Outdated Show resolved Hide resolved
@MrGeek1337
Update slowsort.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
96f68a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmaxguns mrmaxguns

@NumberPiOso NumberPiOso

@mateuszz0000 mateuszz0000

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@MrGeek1337 @mrmaxguns @NumberPiOso
You can’t perform that action at this time.