Added first solution to Project Euler problem 92 #4043
Conversation
sharmapulkit04
requested review from
dhruvmanila and
Kush1101
as code owners
ghost
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
project_euler/problem_092/sol1.py
Outdated
| Appends the list of all the possible ways in which an n digts can | ||
| be distributed among 9 digits at the end of a 2-d list all_distributions. | ||
| >>> all_possible_distributions([],[0]*10,5,0) is None | ||
| True | ||
| >>> all_possible_distributions([],[0]*10,8,0) is None | ||
| True | ||
|
|
There was a problem hiding this comment.
Please provide a better description regarding what the function is doing.
Also, the doctests are redundant. In this function, you're mutating the parameter which is not a good practice. Instead, what you can do is to make a copy of the list and mutate that list and return it. This way you will be able to test this function appropriately.
There was a problem hiding this comment.
The function appends the total no, of ways in which the number current can be distributed among the indices 0-9 of the list. i.e when we add all the contents of each_distribution it will lead to current. The each_distribution list is just a temporary list used to create a particular distribution.The all_distributions is a list of all possible current_distributions. The index starts from 0 and the function recursively increases the index by 1 and terminates when it reaches 9 and then appends the formed each_distribution list to all_distributions list.
There was a problem hiding this comment.
Copying the 2-d list at every recursive call will increase the complexity by a large factor. Though it will be able to solve the problem within the given constraints it will not be able to generalize for a large input taking a toll on the performance of the algorithm.
There was a problem hiding this comment.
Also the function can be modified to return a large 2-d list of all possible distributions but in that case reformatting the returned 2-d list to so that there would max 88 characters in each line cause doctest to fail.
There was a problem hiding this comment.
There was a problem hiding this comment.
Copying the 2-d list at every recursive call will increase the complexity by a large factor. Though it will be able to solve the problem within the given constraints it will not be able to generalize for a large input taking a toll on the performance of the algorithm.
The function uses brute force method to generate all possible combinations ,thus it would make the function very slow. Should I still consider doing it ?
There was a problem hiding this comment.
Maybe you can copy the list first, mutate and finally append to the result for this function? @sharmapulkit04
There was a problem hiding this comment.
I am unable to understand what you are saying @poyea . Are you suggesting to copy the 2-d list at start of function call? If that is the case then what I am trying to say is that the function uses recursion to calculate all possible configurations, so if I copy the entire 2-d list at every recursive call, it will increase the complexity by a large factor and will make the function very slow.
ghost
added
awaiting changes
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.