The Wayback Machine - https://web.archive.org/web/20201020111906/https://github.com/go-sql-driver/mysql/pull/1092
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis allow Go master to fail #1092

Merged
merged 4 commits into from May 8, 2020
Merged

Travis allow Go master to fail #1092

merged 4 commits into from May 8, 2020

Conversation

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented May 4, 2020

Description

We currently test against the master branch of golang/go with Travis CI. That is useful when we need to adapt to changes or want to test against features not yet available in a Go release.

However, the master branch is not always without errors. Currently the cross-compile check errors because for one platform the golang/go master is broken.

This PR allows master to fail: https://travis-ci.com/github/go-sql-driver/mysql/builds/163720889 (also failing here).
Further, it removes the obsolete sudo keys from the travis config.

@julienschmidt julienschmidt mentioned this pull request May 4, 2020
3 of 3 tasks complete
@julienschmidt julienschmidt changed the title Travis allow failure Travis allow Go master to fail May 4, 2020
@julienschmidt julienschmidt requested a review from methane May 7, 2020
@methane
methane approved these changes May 8, 2020
@julienschmidt julienschmidt merged commit f070e56 into master May 8, 2020
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
coverage/coveralls Coverage increased (+0.06%) to 81.693%
Details
@julienschmidt julienschmidt deleted the travis-allow-failure branch May 8, 2020
@dolmen
Copy link
Contributor

@dolmen dolmen commented May 22, 2020

What you call master is in fact called tip by the Go team. See https://tip.golang.org/ which shows the doc for the tip branch. It would be better to use that naming in the Travis config.

@julienschmidt
Copy link
Member Author

@julienschmidt julienschmidt commented May 22, 2020

We used to use tip. That was changed in #693 as Travis uses master for consistency: travis-ci/gimme#102

tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
* travis: allow master branch to fail

* travis: matrix is an alias for jobs

* travis: remove obsolete sudo key

* travis: remove obsolete sudo keys in jobs matrix
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
* travis: allow master branch to fail

* travis: matrix is an alias for jobs

* travis: remove obsolete sudo key

* travis: remove obsolete sudo keys in jobs matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.