The Wayback Machine - https://web.archive.org/web/20210202123538/https://github.com/go-sql-driver/mysql/pull/1170
Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Make usage code more friendly. #1170

Merged
merged 1 commit into from Nov 26, 2020
Merged

README: Make usage code more friendly. #1170

merged 1 commit into from Nov 26, 2020

Conversation

@methane
Copy link
Member

@methane methane commented Nov 25, 2020 •
edited

Description

import time module because time.Minute is used.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
@methane
README: Make usage code more friendly.
Loading status checks…
cc8e331
@shogo82148
shogo82148 approved these changes Nov 25, 2020
View changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

LGTM
@methane methane merged commit aae55f7 into go-sql-driver:master Nov 26, 2020
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.06%) to 82.034%
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@methane methane deleted the methane:example branch Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@methane @shogo82148