The Wayback Machine - https://web.archive.org/web/20210202123656/https://github.com/go-sql-driver/mysql/pull/1116
Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace whitelist/blacklist terminology with allowlist/denylist #1116

Merged
merged 5 commits into from May 29, 2020
Merged

Replace whitelist/blacklist terminology with allowlist/denylist #1116

merged 5 commits into from May 29, 2020
+9 −8

Conversation

@cainejette
Copy link
Contributor

@cainejette cainejette commented May 28, 2020 •
edited

Description

Promoting inclusive terminology by replacing outdated terms with more sensitive equivalents.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Closes #1102
cainejette added 2 commits May 28, 2020
@cainejette
Replace whitelist/blacklist terminology with allowlist/denylist
3ef43c3
@cainejette
Add myself to AUTHORS
Loading status checks…
b45ae03
@cainejette cainejette mentioned this pull request May 28, 2020
Closed
@julienschmidt
julienschmidt reviewed May 28, 2020
View changes
Copy link
Member

@julienschmidt julienschmidt left a comment •
edited

I'm not convinced. These replacements seem a little weird.
I'm also not convinced that there is anything wrong with "blacklist" and "whitelist", just because they contain the words "black" and "white". Those are just colors after all and I don't think they have any racial origin.
Take "whitebox" and "blackbox" for example. One let's light through (white), the other not (black). That's probably a physical origin.
Wikipedia also doesn't mention anything about the term not being inclusive or anything like that. It does however mention "blocklist" as an alternative.
AUTHORS Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cainejette added 2 commits May 28, 2020
@cainejette
PR feedback
Loading status checks…
29a47d0
@cainejette
Denylist --> denied
Loading status checks…
abf54ea
@cainejette
Copy link
Contributor Author

@cainejette cainejette commented May 28, 2020 •
edited

I'm also not convinced that there is anything wrong with "blacklist" and "whitelist", just because they contain the words "black" and "white". Those are just colors after all and I don't think they have any racial origin.

I've had this conversation several times at several different jobs. I've made my peace with it by acknowledging that while I myself may not attribute any unexpected connotations to these words, that speaks to my privilege and that others can and do. It is a simple enough thing for us to substitute alternatives and avoid the issue altogether.
@cainejette
Update denied --> rejected
Loading status checks…
5e99edf
@cainejette
Copy link
Contributor Author

@cainejette cainejette commented May 28, 2020 •
edited

For what it may be worth, I've filed a similar issue (and PR) against HashiCorp Consul: hashicorp/consul#7901, and they acknowledge that several of their products have intentionally moved away from this exact terminology but Consul has not, yet. (I filed issues against Consul and this repo because we use these two repos as dependencies in our own codebase).
@methane
Copy link
Member

@methane methane commented May 29, 2020

Fortunately, we don't use the terminology in public APIs. This PR doesn't break backward compatibility and doesn't make inconsistency between code and document.

So I'm OK for this change if the document is clean and readable.
@methane
methane approved these changes May 29, 2020
View changes
@julienschmidt
julienschmidt approved these changes May 29, 2020
View changes
@julienschmidt julienschmidt merged commit d2e52fc into go-sql-driver:master May 29, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
coverage/coveralls Coverage remained the same at 81.73%
Details
timneutkens added a commit to timneutkens/next.js that referenced this pull request Jun 2, 2020
@timneutkens
Use inclusive naming for variables / examples
1b38658 
The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FILE_NAME_WHITELIST

Prior discussions on this topic:
- hashicorp/consul#7901
- styled-system/styled-system#391
- go-sql-driver/mysql#1116
- lagom/lagom#2532
- grafana/grafana#18841
@timneutkens timneutkens mentioned this pull request Jun 2, 2020
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jun 2, 2020
@timneutkens
Use inclusive naming for variables / examples (#13657)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31b3e46 
https://twitter.com/vercel/status/1267650234236252161

The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FILE_NAME_WHITELIST

Prior discussions on this topic:
- hashicorp/consul#7901
- styled-system/styled-system#391
- go-sql-driver/mysql#1116
- lagom/lagom#2532
- grafana/grafana#18841
@cainejette
Copy link
Contributor Author

@cainejette cainejette commented Jun 8, 2020

Thanks, all!
rokinsky added a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Use inclusive naming for variables / examples (vercel#13657)
35dc709 
https://twitter.com/vercel/status/1267650234236252161

The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FILE_NAME_WHITELIST

Prior discussions on this topic:
- hashicorp/consul#7901
- styled-system/styled-system#391
- go-sql-driver/mysql#1116
- lagom/lagom#2532
- grafana/grafana#18841
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@cainejette @tz70s
Replace whitelist/blacklist terminology with allowlist/denylist (go-s…
ba90c23 
…ql-driver#1116)

* Replace whitelist/blacklist terminology with allowlist/denylist

* Add myself to AUTHORS

* PR feedback

* Denylist --> denied

* Update denied --> rejected
tz70s added a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@cainejette @tz70s
Replace whitelist/blacklist terminology with allowlist/denylist (go-s…
ec54302 
…ql-driver#1116)

* Replace whitelist/blacklist terminology with allowlist/denylist

* Add myself to AUTHORS

* PR feedback

* Denylist --> denied

* Update denied --> rejected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

@julienschmidt julienschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Promote inclusive behavior by removing whitelist/blacklist terminology
3 participants
@cainejette @methane @julienschmidt