The Wayback Machine - https://web.archive.org/web/20221223145353/https://github.com/python/cpython/pull/24027
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40631: Disallow single parenthesized star target #24027

Merged
merged 5 commits into from Jan 2, 2021
Merged

bpo-40631: Disallow single parenthesized star target #24027

merged 5 commits into from Jan 2, 2021

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Dec 31, 2020 •
edited by bedevere-bot

@lysnikolaou lysnikolaou requested a review from pablogsal Dec 31, 2020
@lysnikolaou lysnikolaou mentioned this pull request Dec 31, 2020
Closed
@lysnikolaou lysnikolaou force-pushed the disallow-single-paren-star-target branch from ae3db83 to efe2fb6 Compare Dec 31, 2020
@lysnikolaou lysnikolaou requested a review from gvanrossum Dec 31, 2020
@lysnikolaou lysnikolaou force-pushed the disallow-single-paren-star-target branch from efe2fb6 to 5324fa8 Compare Dec 31, 2020
pablogsal
pablogsal approved these changes Dec 31, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM! 🚀

@lysnikolaou lysnikolaou closed this Jan 2, 2021
@lysnikolaou lysnikolaou reopened this Jan 2, 2021
@gvanrossum
Copy link
Member

gvanrossum commented Jan 2, 2021

If this about nntp failures, you may have to merge master.

@lysnikolaou lysnikolaou merged commit 2ea320d into python:master Jan 2, 2021
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 2, 2021

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@lysnikolaou lysnikolaou deleted the disallow-single-paren-star-target branch Jan 2, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jan 2, 2021

Sorry, @lysnikolaou, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2ea320dddd553298038bb7d6789e50e199332f66 3.9

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Jan 3, 2021
@lysnikolaou
bpo-40631: Disallow single parenthesized star target (pythonGH-24027)
d55cccd 
(cherry picked from commit 2ea320d)
@bedevere-bot
Copy link

bedevere-bot commented Jan 3, 2021

GH-24068 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit that referenced this pull request Jan 3, 2021
@lysnikolaou
[3.9] bpo-40631: Disallow single parenthesized star target (GH-24027) (…
9a608ac 
…GH-24068)

(cherry picked from commit 2ea320d)

Automerge-Triggered-By: GH:pablogsal
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@lysnikolaou @adorilson
bpo-40631: Disallow single parenthesized star target (pythonGH-24027)
065501e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@gvanrossum gvanrossum

Assignees

@lysnikolaou lysnikolaou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lysnikolaou @gvanrossum @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni