The Wayback Machine - https://web.archive.org/web/20210226233358/https://github.com/microsoft/TypeScript/pull/41950
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import fix on react or react dev #41950

Merged
merged 1 commit into from Feb 16, 2021

Conversation

@Kingwl
Copy link
Member

@Kingwl Kingwl commented Dec 14, 2020

Fixes #41920

@xiaoxiangmoe
Copy link

@xiaoxiangmoe xiaoxiangmoe commented Dec 17, 2020

Any update on this?

@Kingwl
Copy link
Member Author

@Kingwl Kingwl commented Dec 18, 2020

@sandersn sandersn added this to Not started in PR Backlog Dec 30, 2020
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Dec 30, 2020
Copy link
Member

@andrewbranch andrewbranch left a comment

Thanks @Kingwl!

PR Backlog automation moved this from Needs review to Needs merge Dec 30, 2020
@gabro
Copy link

@gabro gabro commented Feb 16, 2021

I'm sorry to be that guy, but this PR has been approved almost two months ago. Is there any plan to include it in the next TypeScript release?

This bug makes it very hard when working with the new jsx factory trasform, since auto-import code actions basically just stop working and you end up with a lot of spurious (and unused) imports from 'react'.

@andrewbranch andrewbranch merged commit d6a32e3 into microsoft:master Feb 16, 2021
10 checks passed
10 checks passed
build (10.x)
Details
CodeQL-Build CodeQL-Build
Details
build (12.x)
Details
build (14.x)
Details
CodeQL No new alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
node10 Build #91118 succeeded
Details
node12 Build #91116 succeeded
Details
node14 Build #91117 succeeded
Details
PR Backlog automation moved this from Needs merge to Done Feb 16, 2021
@gabro
Copy link

@gabro gabro commented Feb 16, 2021

Thank you @andrewbranch for the merge! 🙏

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Feb 16, 2021

Sorry @gabro, I wanted to give others a chance to review, and it just slipped through the cracks. This will be released in 4.3 proper, or in the nightly starting tomorrow.

@gabro
Copy link

@gabro gabro commented Feb 16, 2021

No worries, thanks and keep up with the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Backlog
  
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants