The Wayback Machine - https://web.archive.org/web/20210322131609/https://github.com/scikit-learn/scikit-learn/pull/19461
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Set non-interactive installation mode for the pypy job #19461

Merged
merged 10 commits into from Feb 22, 2021

Conversation

@alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Feb 15, 2021

What does this implement/fix? Explain your changes.

This PR fixes the pypy job using non-interactive mode for the installation process (required for tzdata).

alfaro96 added 4 commits Feb 15, 2021
alfaro96 added 3 commits Feb 15, 2021
@alfaro96 alfaro96 changed the title MNT Fix pypy job MNT Set non-interactive mode for the installation process in pypy job Feb 15, 2021
@alfaro96 alfaro96 changed the title MNT Set non-interactive mode for the installation process in pypy job MNT Set non-interactive installation mode for the process in pypy job Feb 15, 2021
@alfaro96 alfaro96 changed the title MNT Set non-interactive installation mode for the process in pypy job MNT Set non-interactive installation mode for the pypy job Feb 15, 2021
@alfaro96
Copy link
Member Author

@alfaro96 alfaro96 commented Feb 15, 2021

The failures in: https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn/11797/workflows/9c81a4ab-b514-475d-8b0d-2c5e7e0e1abf/jobs/132693 seems to be related with numerical precisions errors (further investigation required).

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Feb 21, 2021

To move this forward, we can XFAIL test_kernel_gradient for PYPY and open an issue for it.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

LGTM otherwise

.circleci/config.yml Outdated Show resolved Hide resolved
alfaro96 added 2 commits Feb 22, 2021
@rth
rth approved these changes Feb 22, 2021
Copy link
Member

@rth rth left a comment

Thanks @alfaro96 !

@rth rth merged commit 26c5530 into scikit-learn:main Feb 22, 2021
25 checks passed
25 checks passed
triage
Details
Check build trigger
Details
Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}-${{ matrix.manylinux_image }}
Details
Source distribution
Details
Upload to Anaconda
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
scikit-learn.scikit-learn Build #20210222.13 succeeded
Details
scikit-learn.scikit-learn (Get Git Commit) Get Git Commit succeeded
Details
scikit-learn.scikit-learn (Linting) Linting succeeded
Details
scikit-learn.scikit-learn (Linux py36_conda_openblas) Linux py36_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py36_ubuntu_atlas) Linux py36_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py36_ubuntu_atlas_32bit) Linux32 py36_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl) Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py36_pip_openblas_32bit) Windows py36_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl) macOS pylatest_conda_forge_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp) macOS pylatest_conda_mkl_no_openmp succeeded
Details
@alfaro96 alfaro96 deleted the alfaro96:fix_pypy_job branch Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants