Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Jayasankar-m)

javascript/node/selenium-webdriver/lib/promise.js, line 38 at r1 (raw file):

    // Use array notation so the Closure compiler does not obfuscate away our
    // contract.
    return value != null

!!value to coerce the value to a boolean (instead of value != null)

Also, you should update the tests since they currently do nothing...

/test/lib/promise_test.js -- remove lines 59&60, replace with this test:

it('isPromise', () => {
const v = () => {};
const x = new Promise(v, v);
const p = createRejectedPromise('reject');
assert.equal(true, promise.isPromise(x));
assert.equal(true, promise.isPromise(p));
assert.equal(false, promise.isPromise(0));
assert.equal(false, promise.isPromise(false));
assert.equal(false, promise.isPromise(true));
assert.equal(false, promise.isPromise(null));
assert.equal(false, promise.isPromise(undefined));
assert.equal(false, promise.isPromise(''));
assert.equal(false, promise.isPromise('promise'));
assert.equal(false, promise.isPromise(v));
});

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jayasankar-m)

javascript/node/selenium-webdriver/lib/promise.js, line 38 at r1 (raw file):

In fact, you can completely remove the value && part and just have:

        return (typeof value === 'object' || typeof value === 'function')
        && typeof value['then'] === 'function';

And it will still pass all of those tests.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martin770)

javascript/node/selenium-webdriver/lib/promise.js, line 38 at r1 (raw file):

Done.
Updated as per review comments

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

You are right, a recent PR merge fixed this. I will merge the test, thank you.