The Wayback Machine - https://web.archive.org/web/20201127050001/https://github.com/litehtml/litehtml/issues/141
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument error #141

Open
eco747 opened this issue Oct 5, 2020 · 1 comment
Open

argument error #141

eco747 opened this issue Oct 5, 2020 · 1 comment

Comments

@eco747
Copy link

@eco747 eco747 commented Oct 5, 2020

in html_tag.cpp line 4249

        // re-render with new width
	if (ret_width < max_width && !second_pass && have_parent())
	{
		if (m_display == display_inline_block ||
			(m_css_width.is_predefined() &&
			(m_float != float_none ||
			m_display == display_table ||
			m_el_position == element_position_absolute ||
			m_el_position == element_position_fixed
			))
			)
		{
			render(x, y, ret_width, true);  <<<<<<<<< HERE THE 3RD ARG SHOULD NOT BE A BOOLEAN BUT A HEIGHT
			m_pos.width = ret_width - (content_margins_left() + content_margins_right());
		}
	}
@tordex
Copy link
Member

@tordex tordex commented Oct 12, 2020

Looks all right here. This is the definition of function render: int litehtml::html_tag::render( int x, int y, int max_width, bool second_pass ) 3rd parameter is boolean and indicates the second pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.