The Wayback Machine - https://web.archive.org/web/20210419212738/https://github.com/laravel/framework/pull/37022
Skip to content

/ framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SoftDeletes docblock #37022

Merged
merged 1 commit into from Apr 17, 2021
Merged

Update SoftDeletes docblock #37022

merged 1 commit into from Apr 17, 2021
+2 −1

Conversation

@canvural
Copy link
Contributor

@canvural canvural commented Apr 17, 2021

SoftDeletingScope also adds restore method.

So this PR:

  • changes the docblock for SoftDeletes trait to include restore method
  • fixes withTrashed method docblock, so that it accepts a bool argument
@canvural
Update SoftDeletes docblock
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
214f6f2
@taylorotwell taylorotwell merged commit 02fd52f into laravel:8.x Apr 17, 2021
15 checks passed
15 checks passed
PHP 7.3 - prefer-lowest
Details
PHP 7.3 - prefer-stable
Details
PHP 7.4 - prefer-lowest
Details
PHP 7.4 - prefer-stable
Details
PHP 8.0 - prefer-lowest
Details
PHP 8.0 - prefer-stable
Details
PHP 8.1 - prefer-stable PHP 8.1 - prefer-stable
Details
PHP 7.3 - prefer-lowest - Windows
Details
PHP 7.3 - prefer-stable - Windows
Details
PHP 7.4 - prefer-lowest - Windows
Details
PHP 7.4 - prefer-stable - Windows
Details
PHP 8.0 - prefer-lowest - Windows
Details
PHP 8.0 - prefer-stable - Windows
Details
PHP 8.1 - prefer-stable - Windows PHP 8.1 - prefer-stable - Windows
Details
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@canvural @taylorotwell