Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Implement a text editor feature #875
Merged
+82
−0
Conversation
|
Looks good. I mean always could just use nano or whatever in the CLI, but another r option is another option I guess :D |
Repository owner
deleted a comment from
rodrigovssp
Nov 10, 2020
|
Just started using eDEX UI, this is pretty sweet |
|
Hell, why not. Thanks! |
|
Are you in the MATRIX?
Kind regards,
Raza
On Tue, Nov 10, 2020 at 1:32 AM Surge ***@***.***> wrote:
Not sure if this would be useful or not, but I added a text editor that
you can use through the file system. You can click a file in the file
explorer and it will open a popup that displays the filename (and
extension), and the content of the file that's currently there. I've
provided screenshots as well.
[image: Capture]
<https://user-images.githubusercontent.com/22083792/98591674-8ebf2200-229e-11eb-8a0e-6d1b08f72c7f.PNG>
Open in the tron-disrupted theme
[image: Capture2]
<https://user-images.githubusercontent.com/22083792/98591711-9f6f9800-229e-11eb-903c-913ed4c3a195.PNG>
Open in the red theme
Right now, the only kinds of files that can be opened are HTML, CSS,
Javascript, XML, Yaml, Java, C#, C++ and H, Markdown, Batch and Shell,
GDscript (godot engine <https://godotengine.org/>), JSON (excludes the
themes, keyboards, settings.json, and shortcuts.json), plain text, and log
files, though that list can be expanded as needed.
In the future, I might try to make the different file types able to be
differentiated by their icons, though that's a project for another day. I
might also have the text inside the textarea a little bigger, and maybe
always white, because the red theme is really hard to read from the default
monospace font. Lmk if I need to make any changes
------------------------------
You can view, comment on, or merge this pull request online at:
#875
Commit Summary
- Fix #861
- Implement text editor feature - Surge
- Merge branch 'master' of https://github.com/Animus-Surge/edex-ui
File Changes
- *M* src/_renderer.js
<https://github.com/GitSquared/edex-ui/pull/875/files#diff-4216fe265d035f9f22daac4c27493244235520b219173244faf05d7bba5d92f8>
(6)
- *M* src/assets/css/modal.css
<https://github.com/GitSquared/edex-ui/pull/875/files#diff-cee340ca6029b7025bafc07aca06ba1314b85ea535e4cc649d4eaa52f41062fe>
(13)
- *M* src/classes/filesystem.class.js
<https://github.com/GitSquared/edex-ui/pull/875/files#diff-cd0f687aeb1dae1e9f78d9a3fa6f2473f81e1ec510c445c0e5c98c3a020085e8>
(63)
Patch Links:
- https://github.com/GitSquared/edex-ui/pull/875.patch
- https://github.com/GitSquared/edex-ui/pull/875.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#875>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGK5THNHEKEBBPHNOIWN5TSPBGXRANCNFSM4TP2HEXQ>
.
--
Raza Amir
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Not sure if this would be useful or not, but I added a text editor that you can use through the file system. You can click a file in the file explorer and it will open a popup that displays the filename (and extension), and the content of the file that's currently there. I've provided screenshots as well.
Open in the tron-disrupted theme
Open in the red theme
Right now, the only kinds of files that can be opened are HTML, CSS, Javascript, XML, Yaml, Java, C#, C++ and H, Markdown, Batch and Shell, GDscript (godot engine), JSON (excludes the themes, keyboards, settings.json, and shortcuts.json), plain text, and log files, though that list can be expanded as needed.
In the future, I might try to make the different file types able to be differentiated by their icons, though that's a project for another day. I might also have the text inside the
textareaa little bigger, and maybe always white, because the red theme is really hard to read from the default monospace font. Lmk if I need to make any changes