The Wayback Machine - https://web.archive.org/web/20201202201428/https://github.com/GitSquared/edex-ui/pull/892
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #873 #892

Merged
merged 1 commit into from Nov 15, 2020
Merged

Fix issue #873 #892

merged 1 commit into from Nov 15, 2020

Conversation

@Animus-Surge
Copy link
Contributor

@Animus-Surge Animus-Surge commented Nov 15, 2020

The issue described a crash when opening a previously closed tty instance. The issue appeared to be windows specific, as when I tested this on my raspberry pi the issue did not occur. All I did was add a try catch block where the terminal gets resized and ignore the error, which appeared to fix the issue.

Copy link
Owner

@GitSquared GitSquared left a comment

Nice one. Thanks!

@GitSquared GitSquared merged commit c944d75 into GitSquared:master Nov 15, 2020
2 checks passed
2 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
security/snyk (GitSquared) No manifest changes detected in 2 projects
Details
@prototype99
Copy link

@prototype99 prototype99 commented Nov 20, 2020

just as a footnote in case anyone is debating whether they need this, I can say for certain that it does affect some Linux systems. tested on Gentoo 17.0 (yeah, I really should update to 17.1, I know)

@lebarde lebarde mentioned this pull request Nov 25, 2020
18 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.