The Wayback Machine - https://web.archive.org/web/20201202201420/https://github.com/GitSquared/edex-ui/pull/905
Skip to content

/ edex-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logic error in last commit #905

Merged
merged 2 commits into from Nov 20, 2020
Merged

fix logic error in last commit #905

merged 2 commits into from Nov 20, 2020

Conversation

@wrac4242
Copy link
Contributor

@wrac4242 wrac4242 commented Nov 20, 2020

possibly causes an issue with leaving a core free? seeing the changes in the latest commit on master
@wrac4242
Update _multithread.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
be2a82b 
possibly causes an issue with leaving a core free?
@GitSquared
GitSquared requested changes Nov 20, 2020
View changes
Copy link
Owner

@GitSquared GitSquared left a comment

Oh yeah, good catch... I need to finish my morning coffee.
src/_multithread.js Outdated Show resolved Hide resolved
@GitSquared
Update _multithread.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85e68eb
@GitSquared
GitSquared approved these changes Nov 20, 2020
View changes
@GitSquared GitSquared changed the title Update _multithread.js fix logic error in last commit Nov 20, 2020
@GitSquared GitSquared merged commit c608bd6 into GitSquared:master Nov 20, 2020
2 checks passed
2 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
security/snyk (GitSquared) No manifest changes detected in 2 projects
Details
@lebarde lebarde mentioned this pull request Nov 25, 2020
Closed
18 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitSquared GitSquared

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wrac4242 @GitSquared
You can’t perform that action at this time.