fix(DataResolver): fix circular dependency error with GuildTemplate #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherryblossom000
commented
May 13, 2021
|
|
||
| describe('resolveGuildTemplateCode', () => { | ||
| test('basic', () => { | ||
| expect(DataResolver.resolveGuildTemplateCode('https://discord.new/abc')).toBe('abc'); |
There was a problem hiding this comment.
I wasn't sure if this test is really necessary, but because I technically changed the code in resolveGuildTemplateCode, I added this just in case. I'm happy to remove it if this is unnecessary.
There don't seem to be many existing tests, so I just copied what was in test/escapeMarkdown.test.js.
cherryblossom000
commented
May 13, 2021
| /* eslint-disable max-len, no-undef */ | ||
| /* eslint-env jest */ | ||
| /* eslint-disable max-len */ |
There was a problem hiding this comment.
I noticed that jest is listed as a dev dependency in package.json, so I enabled the jest ESLint environment so that no-undef can still be enabled without spewing warnings about describe, test, and expect being undefined.
iCrawl
reviewed
May 22, 2021
iCrawl
approved these changes
May 22, 2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please describe the changes this PR makes and why it should be merged:
Fixes #5600
Status and versioning classification: