The Wayback Machine - https://web.archive.org/web/20250521192708/https://github.com/TheAlgorithms/Python/pull/4405
Skip to content

Create quickmultiplication.py #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Create quickmultiplication.py #4405

wants to merge 1 commit into from

Conversation

Rohit-beep-droid
Copy link

Describe your change:

A newer pull request of the previous quickmultiply.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Rohit-beep-droid Rohit-beep-droid requested a review from Kush1101 as a code owner May 6, 2021 18:14
@ghost ghost added require type hints https://docs.python.org/3/library/typing.html awaiting reviews This PR is ready to be reviewed labels May 6, 2021
ghost
ghost reviewed May 6, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/quickmultiplication.py
return num*num2


def test_quick_multiply():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: test_quick_multiply. If the function does not return a value, please provide the type hint as: def function() -> None:

@ghost ghost added the tests are failing Do not merge until tests pass label May 12, 2021
@onlinejudge95
Copy link
Collaborator

Is related to #4403

@9harshit
Copy link
Contributor

could use float to include real numbers

@mrmaxguns mrmaxguns added the duplicate This is a duplicate PR from the same user label May 29, 2021
@mrmaxguns
Copy link
Member

mrmaxguns commented May 29, 2021 •
edited
Loading

I'm closing this as a duplicate of the pull request you made with the same exact code previously (#4403). Please comment if this is a misunderstanding. Please add changes to your previous PR instead of opening a new one.

@mrmaxguns mrmaxguns closed this May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed duplicate This is a duplicate PR from the same user require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rohit-beep-droid @onlinejudge95 @9harshit @mrmaxguns