The Wayback Machine - https://web.archive.org/web/20210118113015/https://github.com/TheAlgorithms/Dart/pull/95
Skip to content

/ Dart

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linked list tests #95

Merged
merged 20 commits into from Oct 16, 2020
Merged

Linked list tests #95

merged 20 commits into from Oct 16, 2020

Conversation

@Parowicz
Copy link
Contributor

@Parowicz Parowicz commented Oct 15, 2020

Welcome to Dart community

I've changed github action to run all tests from all folders /.dart and subfolders //*.dart. I don't have ideas how to force dart to traverse whole directory tree.

Also I've encountered some mirror bugs. Most of them is fixed, but I'll have to spend more time on remaining ones.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Dart files are placed inside an existing directory.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Parowicz and others added 14 commits Oct 15, 2020
@Parowicz
Merge pull request #3 from TheAlgorithms/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d61a58b 
Sync Fork
@Parowicz
Add test suit and test cases for linked list
Loading status checks…
7cec959
@Parowicz
Update dart_test_analyze_format.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1e70c4f
@cclauss
dart pub get
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
75017c5
@cclauss
Update dart_test_analyze_format.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c11ac7d
@Parowicz
Update dart_test_analyze_format.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
522d691
@cclauss
Create README.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0512b33
@cclauss
dart test data_structures/linked_list.dart
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd50f44
@Parowicz
Update dart_test_analyze_format.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f74fc0d
@Parowicz
Update dart_test_analyze_format.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3f91119
@Parowicz
Update dart_test_analyze_format.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
394cfd6
@Parowicz
Fix small test errors
5c64d98
@Parowicz
Merge branch 'master' into linked-list-tests
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f557e97
@Parowicz
Update pubspec.yaml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
29c441a
@cclauss
cclauss reviewed Oct 15, 2020
View changes
pubspec.yaml Outdated Show resolved Hide resolved
@Parowicz @cclauss
Update pubspec.yaml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
08ffd73 
Co-authored-by: Christian Clauss <[email protected]>
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

AWESOME!!
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

Should we put @Skip('currently failing (see issue #86)') at the top of math/fermats_little_theorem.dart?
@Parowicz
Copy link
Contributor Author

@Parowicz Parowicz commented Oct 15, 2020

Unfortunate it's compilation error. I can fix types in this file and raise generic fail until issue is resolved.
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

So the @Skip does not prevent dart test from compiling the file?
@Parowicz
Copy link
Contributor Author

@Parowicz Parowicz commented Oct 15, 2020

Nvm it's just too late. It will work as you say.
Parowicz added 5 commits Oct 15, 2020
@Parowicz
Skip fermant_little_theorem and fix type errors
01e4825
@Parowicz
Merge branch 'linked-list-tests' of https://github.com/Parowicz/Dart …
Loading status checks…
2070288 
…into linked-list-tests
@Parowicz
Catch error in binary_to_decimal
Loading status checks…
ff748dc
@Parowicz
Add dart_test.yaml
c5c9aa5
@Parowicz
Update github action to use dart_test.yaml
Loading status checks…
e058fc0
@Parowicz
Copy link
Contributor Author

@Parowicz Parowicz commented Oct 15, 2020

Ok, now it looks fine. Using *.yaml config files solved all the problems.
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

VERY IMPRESSIVE!!
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 15, 2020

Ready for Review?
@Parowicz Parowicz marked this pull request as ready for review Oct 15, 2020
@cclauss
cclauss approved these changes Oct 15, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM!!!
@cclauss cclauss merged commit 41d45b7 into TheAlgorithms:master Oct 16, 2020
1 check passed
1 check passed
dart_test_analyze_format
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Parowicz @cclauss
You can’t perform that action at this time.