The Wayback Machine - https://web.archive.org/web/20201103184625/https://github.com/TheAlgorithms/Java/pull/1266
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved problem of lowercase letters #1266

Open
wants to merge 1 commit into
base: master
from

Conversation

@aniket3991
Copy link

@aniket3991 aniket3991 commented Apr 6, 2020

solved problem with lowercase letters

@drabbit75
Copy link
Member

@drabbit75 drabbit75 commented Aug 25, 2020

it seems not to solve lowercase letter problem . do you want to solve "n=0" bug ?

@drabbit75
Copy link
Member

@drabbit75 drabbit75 commented Aug 27, 2020

ready to close with the doubt

@aniket3991
Copy link
Author

@aniket3991 aniket3991 commented Aug 27, 2020

@drabbit75 can you give me an input where you find problems in lower case letters

@drabbit75
Copy link
Member

@drabbit75 drabbit75 commented Aug 28, 2020

@drabbit75 can you give me an input where you find problems in lower case letters

the codes seems not to solve "lower case problem", what bugs do you want to fix

@aniket3991
Copy link
Author

@aniket3991 aniket3991 commented Aug 28, 2020

actually what was happening that you have to write the values of "abcdef" in capital letters for its converstion in any base otheswise it was not working so i fixed it

@drabbit75
Copy link
Member

@drabbit75 drabbit75 commented Aug 31, 2020

in the codes :
{'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E',
'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V',
'W', 'X', 'Y', 'Z'};" // digitsForBase contains all the valid digits for the base given".
this limits the input and I think it is not a bug and not neccesary to fix personally.

@aniket3991
Copy link
Author

@aniket3991 aniket3991 commented Sep 9, 2020

So you can say that i expanded the input limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.