Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd BigInteger implementation to Factorial.java #1683
Conversation
|
The BigInteger implementation seems to be a proper one |
|
@ShivamShekhar1997 Is the issue is still open and if yes can you tell me what needs to be done? |
No @sanjana1604 I guess the implementation is a good one and I don't see the need of any changes, just needs to be merged, thanks anyways! |
|
If the PR is valid please get it merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
The previous implementation of Math/Factorial.java involved usage of
longdatatypes that have large storage, but it cannot even handle 100 factorial. So to solve this, I have implemented the algorithm usingjava.math.BigIntegerwhich can store values upto 2^32-1 digits.BigInteger Oracle Documentation
References
Issue #1682 - Add BigInteger Implementation to Factorial.java
Checklist: