The Wayback Machine - https://web.archive.org/web/20201103183714/https://github.com/TheAlgorithms/Java/pull/1726
Skip to content

/ Java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LongestCommonSubstring #1726

Open
wants to merge 1 commit into
base: master
from
Open

LongestCommonSubstring #1726

wants to merge 1 commit into from

Conversation

@Himsahu
Copy link

@Himsahu Himsahu commented Oct 10, 2020

The length of the longest substring common in both the strings

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Himsahu
LongestCommonSubstring
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f63dac9 
 The length of the longest substring common in both the strings
@Himsahu
Copy link
Author

@Himsahu Himsahu commented Oct 10, 2020

Accept my pull request
@ankitbeniwal
ankitbeniwal approved these changes Oct 11, 2020
View changes
@Himsahu
Copy link
Author

@Himsahu Himsahu commented Oct 12, 2020

Still, my pull request is not accepted by the author. Accept it so that I can complete my task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitbeniwal ankitbeniwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Himsahu @ankitbeniwal
You can’t perform that action at this time.